Fix deepsource: VET-V0008 lock erroneously passed by value pkg/discoverer #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…coverer Signed-off-by: vankichi <kyukawa315@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/discoverer
team/set
Signed-off-by: vankichi <kyukawa315@gmail.com>
Deploying with
|
| Latest commit: |
5231969
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://514950af.vald.pages.dev |
| Branch Preview URL: | https://refactor-vet-v0008-lock-erro.vald.pages.dev |
Codecov ReportBase: 30.56% // Head: 30.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1857 +/- ##
==========================================
- Coverage 30.56% 30.56% -0.01%
==========================================
Files 367 367
Lines 33828 33828
==========================================
- Hits 10341 10340 -1
- Misses 23075 23077 +2
+ Partials 412 411 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: vankichi <kyukawa315@gmail.com>
…y-value/pkg-discoverer
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
…y-value/pkg-discoverer
kevindiu
approved these changes
Nov 22, 2022
…y-value/pkg-discoverer
vankichi
deleted the
refactor/VET-V0008/lock-erroneously-passed-by-value/pkg-discoverer
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have fixed
VET-V0008under thepkg/discovererdirectory.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: