Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 lock erroneously passed by value internal/iocopy, info, errgroup #1860

Conversation

vankichi
Copy link
Contributor

Description:

I have fixed VET-V0008 under the internal/info, internal/iocoppy, and internal/errgroup.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

…l/info,iocopy,errgroup

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.52% // Head: 30.51% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2c98827) compared to base (dc4c84c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1860      +/-   ##
==========================================
- Coverage   30.52%   30.51%   -0.02%     
==========================================
  Files         367      367              
  Lines       33828    33828              
==========================================
- Hits        10327    10323       -4     
- Misses      23087    23091       +4     
  Partials      414      414              
Impacted Files Coverage Δ
internal/info/info.go 88.35% <100.00%> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.30% <0.00%> (-3.28%) ⬇️
internal/errgroup/group.go 93.00% <0.00%> (-2.00%) ⬇️
internal/worker/worker.go 82.30% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (+1.26%) ⬆️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c98827
Status: ✅  Deploy successful!
Preview URL: https://5aacbdde.vald.pages.dev
Branch Preview URL: https://refactor-vet-v0008-lock-erro-908d.vald.pages.dev

View logs

@vankichi vankichi merged commit 682f68d into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V0008/lock-erroneously-passed-by-value/info-iocopy-errgroup branch November 22, 2022 03:34
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants