Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 Lock erroneously passed by value (internal/test, singleflight, observability) #1863

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Nov 22, 2022

Description:

As titled

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.54% // Head: 30.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (8acb023) compared to base (331dbb2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1863      +/-   ##
==========================================
- Coverage   30.54%   30.53%   -0.02%     
==========================================
  Files         367      367              
  Lines       33828    33828              
==========================================
- Hits        10333    10328       -5     
- Misses      23081    23086       +5     
  Partials      414      414              
Impacted Files Coverage Δ
internal/worker/queue.go 96.20% <0.00%> (-3.80%) ⬇️
internal/errgroup/group.go 94.00% <0.00%> (-1.00%) ⬇️
internal/worker/worker.go 83.07% <0.00%> (-0.77%) ⬇️
internal/core/algorithm/ngt/ngt.go 63.28% <0.00%> (-0.65%) ⬇️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

kevindiu
kevindiu previously approved these changes Nov 22, 2022
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8acb023
Status: ✅  Deploy successful!
Preview URL: https://14ea5d7b.vald.pages.dev
Branch Preview URL: https://refactor-vet-v0008-lock-erro-u4le.vald.pages.dev

View logs

@hlts2 hlts2 requested a review from kevindiu November 22, 2022 05:11
@vankichi vankichi merged commit fd21b97 into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V0008/lock-error branch November 22, 2022 06:57
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants