Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: VET-V0008 lock erroneously passed by value info #1864

Merged

Conversation

vankichi
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi changed the title ♻️ Fix deepsource: VET-V0008 lock erroneously passed by value info Fix deepsource: VET-V0008 lock erroneously passed by value info Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 30.54% // Head: 30.52% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5de1e4e) compared to base (288e665).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1864      +/-   ##
==========================================
- Coverage   30.54%   30.52%   -0.02%     
==========================================
  Files         367      367              
  Lines       33828    33828              
==========================================
- Hits        10333    10327       -6     
- Misses      23083    23087       +4     
- Partials      412      414       +2     
Impacted Files Coverage Δ
internal/info/info.go 88.35% <100.00%> (ø)
...ent/core/ngt/service/vqueue/undeleted_index_map.go 68.30% <0.00%> (-3.28%) ⬇️
internal/errgroup/group.go 94.00% <0.00%> (-1.00%) ⬇️
internal/net/dialer.go 76.74% <0.00%> (-0.67%) ⬇️
internal/worker/worker.go 83.84% <0.00%> (+2.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi merged commit 331dbb2 into main Nov 22, 2022
@vankichi vankichi deleted the refactor/VET-V0008/lock-erroneously-passed-by-value/info branch November 22, 2022 05:33
@vankichi vankichi restored the refactor/VET-V0008/lock-erroneously-passed-by-value/info branch November 22, 2022 12:29
@kpango kpango mentioned this pull request Jan 19, 2023
@vankichi vankichi deleted the refactor/VET-V0008/lock-erroneously-passed-by-value/info branch February 8, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants