Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deepsource: RVV-B0001 Confusing naming of struct fields or methods #1875

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Nov 25, 2022

Signed-off-by: kevindiu kevindiujp@gmail.com

Description:

SSIA.
pool/get implementation skips this warning. It is because the we may need some discussion and refactor later.

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 25, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb6b7ce
Status: ✅  Deploy successful!
Preview URL: https://2458c5e7.vald.pages.dev
Branch Preview URL: https://refactor-rvv-b0001-confusing-s2gx.vald.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 30.50% // Head: 30.53% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (cb6b7ce) compared to base (8a157f9).
Patch coverage: 72.72% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
+ Coverage   30.50%   30.53%   +0.02%     
==========================================
  Files         367      367              
  Lines       33821    33821              
==========================================
+ Hits        10318    10327       +9     
+ Misses      23090    23080      -10     
- Partials      413      414       +1     
Impacted Files Coverage Δ
internal/net/grpc/pool/pool.go 0.00% <0.00%> (ø)
internal/info/info.go 88.42% <100.00%> (ø)
internal/test/data/vector/gen.go 92.85% <100.00%> (ø)
internal/net/dialer.go 78.40% <0.00%> (+0.99%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+2.00%) ⬆️
...ent/core/ngt/service/vqueue/undeleted_index_map.go 73.77% <0.00%> (+2.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kevindiu <kevindiujp@gmail.com>
@vankichi vankichi merged commit 95d169d into main Nov 25, 2022
@vankichi vankichi deleted the refactor/RVV-B0001/confusing-naming-of-struct-fields-or-methods-part2 branch November 25, 2022 05:04
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants