Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functional option (internal/net/grpc) #1877

Merged

Conversation

vankichi
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 30.49% // Head: 30.51% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (e642160) compared to base (95d169d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   30.49%   30.51%   +0.02%     
==========================================
  Files         367      367              
  Lines       33821    33821              
==========================================
+ Hits        10313    10322       +9     
+ Misses      23092    23086       -6     
+ Partials      416      413       -3     
Impacted Files Coverage Δ
internal/net/grpc/option.go 4.93% <ø> (ø)
internal/net/http/middleware/timeout.go 91.11% <0.00%> (-2.23%) ⬇️
internal/info/info.go 88.42% <0.00%> (ø)
internal/worker/worker.go 83.07% <0.00%> (+0.76%) ⬆️
pkg/agent/core/ngt/service/option.go 91.41% <0.00%> (+1.84%) ⬆️
...nt/core/ngt/service/vqueue/uninserted_index_map.go 73.65% <0.00%> (+3.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit eeb9b56 into main Nov 28, 2022
@vankichi vankichi deleted the refactor/internal/remove-deprecated-functional-option-net-grpc branch November 28, 2022 06:33
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants