Remove blank when all parameters are not used and Add ErrJobFuncNotFound #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <kyukawa315@gmail.com>
vankichi
commented
Nov 28, 2022
internal/errors/worker.go
Outdated
Comment on lines
48
to
50
| ErrJobFuncNotFound = func() error { | ||
| return New("JobFunc is not found") | ||
| } |
There was a problem hiding this comment.
vankichi
changed the title
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov ReportBase: 50.23% // Head: 30.37% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1879 +/- ##
===========================================
- Coverage 50.23% 30.37% -19.87%
===========================================
Files 231 365 +134
Lines 13464 33763 +20299
===========================================
+ Hits 6764 10254 +3490
- Misses 6499 23094 +16595
- Partials 201 415 +214
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
kevindiu
reviewed
Nov 28, 2022
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Deploying with
|
| Latest commit: |
dda5e15
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ca89872d.vald.pages.dev |
| Branch Preview URL: | https://refactor-internal-pkg-remove.vald.pages.dev |
kevindiu
previously approved these changes
Nov 28, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: vankichi <kyukawa315@gmail.com>
kpango
previously approved these changes
Dec 1, 2022
Signed-off-by: vankichi <kyukawa315@gmail.com>
kevindiu
approved these changes
Dec 1, 2022
…paramteres-are-not-used-and-add-ErrJobNotFound-function
kpango
approved these changes
Dec 1, 2022
vankichi
deleted the
refactor/internal-pkg/remove-blank-when-all-paramteres-are-not-used-and-add-ErrJobNotFound-function
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have removed the blank
_when all the parameters are not used in the target function or method.And more, I have added the
ErrJobFuncNotFoundto return thenot found errorat theinternal/worker/queue.go.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: