Fixed a bug that could cause duplicate counts of working_memory_set_bytes #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kpango
added
team/sre
|
Can you please sign CLA ? |
takuyaymd
force-pushed
the
bugfix/dashboard/fix-memory-duplicate-count
branch
from
5120b24
to
cc9152e
Compare
Sorry, I screwed up setting up the author! |
|
@all-contributors please add @takuyaymd for bug, code |
|
I've put up a pull request to add @takuyaymd! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the container_memory_working_set_bytes metric,
Fixed a bug that could cause duplicate data to be summed if this metric was outputting the Pod's own data, not just the data for each container contained in the Pod.
I used the
imagelabel value to distinguish between per-container data and other data.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: