Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: grafana dashboard #1914

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Bugfix: grafana dashboard #1914

merged 1 commit into from
Dec 20, 2022

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Dec 19, 2022

Description:

WHAT

I have fixed invalid character error for grafana dashbaord

WHY

When I deployed grafana, all dashboards were not visible due to invalid key errors

grafana-855cbdc6d5-4h7rz grafana logger=provisioning.dashboard type=file name=dashboards-vald t=2022-12-19T11:09:11.329654054Z level=error msg="failed to load dashboard from " file=/var/lib/grafana/dashboards-vald/02/vald-discoverer.json error="invalid character '\"' after object key:value pair"

Related Issue:

Versions:

  • Go Version: 1.19.4
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 self-assigned this Dec 19, 2022
@github-actions github-actions bot added size/S type/bug Something isn't working priority/medium labels Dec 19, 2022
@hlts2
Copy link
Contributor Author

hlts2 commented Dec 19, 2022

📝 I think I have solved this problem because dashboars were displayed.
スクリーンショット 148

スクリーンショット 147

@kpango
Copy link
Collaborator

kpango commented Dec 19, 2022

I think we should add deployment test for grafana configuration on the ci.

@hlts2 hlts2 requested a review from datelier December 20, 2022 04:54
@hlts2
Copy link
Contributor Author

hlts2 commented Dec 20, 2022

Thank you for your suggestion.
I have investigated and I think we can use the following OSS project.

https://github.com/grafana/dashboard-linter

@kpango kpango merged commit cad800c into main Dec 20, 2022
@kpango kpango deleted the bugfix/k8s/fix-invalid-character branch December 20, 2022 09:13
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants