Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Insert Upsert Testing #1919

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 2, 2023

Signed-off-by: kpango kpango@vdaas.org

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.19.4
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.8

Checklist:

Special notes for your reviewer:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 2, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79e59e9
Status: ✅  Deploy successful!
Preview URL: https://596e5728.vald.pages.dev
Branch Preview URL: https://refactor-agent-insert-upsert.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jan 2, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Base: 30.02% // Head: 29.99% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (79e59e9) compared to base (b9447c8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   30.02%   29.99%   -0.04%     
==========================================
  Files         365      365              
  Lines       33701    33701              
==========================================
- Hits        10119    10107      -12     
- Misses      23173    23185      +12     
  Partials      409      409              
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/ngt.go 20.47% <100.00%> (ø)
pkg/agent/core/ngt/service/vqueue/indexmap.go 77.00% <0.00%> (-5.89%) ⬇️
internal/worker/worker.go 81.53% <0.00%> (-1.54%) ⬇️
internal/net/http/middleware/timeout.go 93.33% <0.00%> (+2.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the refactor/agent/insert-upsert-test branch 2 times, most recently from 2d63012 to 7c9c7d4 Compare January 2, 2023 12:20
@kpango kpango force-pushed the refactor/agent/insert-upsert-test branch from 7c9c7d4 to fb7f4c8 Compare January 2, 2023 12:31
Signed-off-by: kpango <kpango@vdaas.org>
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango requested a review from hlts2 January 10, 2023 08:02
@kpango kpango requested a review from kevindiu January 10, 2023 08:02
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpango kpango merged commit a52fb58 into main Jan 10, 2023
@kpango kpango deleted the refactor/agent/insert-upsert-test branch January 10, 2023 08:07
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants