Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix grpc status handling for idle connection #1921

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jan 16, 2023

Description:

WHAT

When a connection status becomes IDLE, create a new connection and discard the old one.

WHY

If for some reason the component dropped (scale down ...etc.), the connection remains in an IDLE state at the origin (for a few minutes or so).
Due to the above, attempts to issue a request to a connection in the IDLE state will fail.

Related Issue:

Versions:

  • Go Version: 1.19.4
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested review from kpango and datelier January 16, 2023 10:26
@hlts2 hlts2 self-assigned this Jan 16, 2023
@github-actions github-actions bot added size/S type/bug Something isn't working priority/medium labels Jan 16, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jan 16, 2023

Codecov Report

Base: 50.23% // Head: 30.01% // Decreases project coverage by -20.22% ⚠️

Coverage data is based on head (b0d517f) compared to base (97eed29).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1921       +/-   ##
===========================================
- Coverage   50.23%   30.01%   -20.23%     
===========================================
  Files         231      365      +134     
  Lines       13464    33704    +20240     
===========================================
+ Hits         6764    10115     +3351     
- Misses       6499    23181    +16682     
- Partials      201      408      +207     
Impacted Files Coverage Δ
cmd/agent/core/ngt/main.go 0.00% <ø> (ø)
cmd/agent/sidecar/main.go 0.00% <ø> (ø)
cmd/discoverer/k8s/main.go 0.00% <ø> (ø)
cmd/gateway/filter/main.go 0.00% <ø> (ø)
cmd/gateway/lb/main.go 0.00% <ø> (ø)
cmd/manager/index/main.go 0.00% <ø> (ø)
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
cmd/tools/cli/vdctl/main.go 0.00% <ø> (ø)
internal/observability/metrics/info/info.go 0.00% <0.00%> (-100.00%) ⬇️
internal/errors/vald.go 50.00% <0.00%> (-16.67%) ⬇️
... and 257 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@hlts2 hlts2 merged commit fd86b5c into main Jan 17, 2023
@hlts2 hlts2 deleted the bugfix/internal/net-grpc-connection-handling branch January 17, 2023 02:21
@kpango kpango mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants