-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix grpc status handling for idle connection #1921
Conversation
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 50.23% // Head: 30.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1921 +/- ##
===========================================
- Coverage 50.23% 30.01% -20.23%
===========================================
Files 231 365 +134
Lines 13464 33704 +20240
===========================================
+ Hits 6764 10115 +3351
- Misses 6499 23181 +16682
- Partials 201 408 +207
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Finternal%2Fnet-grpc-connection-handling/50bc14979e8f7c33ec5079221d47bb7f6c64c3e8 |
Profile Report
|
Description:
WHAT
When a connection status becomes IDLE, create a new connection and discard the old one.
WHY
If for some reason the component dropped (scale down ...etc.), the connection remains in an IDLE state at the origin (for a few minutes or so).
Due to the above, attempts to issue a request to a connection in the IDLE state will fail.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: