Refactor: Add t.Helper() on test helper function #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/agent/core
team/set
Codecov ReportBase: 29.99% // Head: 29.97% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
- Coverage 29.99% 29.97% -0.02%
==========================================
Files 366 366
Lines 33704 33704
==========================================
- Hits 10108 10103 -5
- Misses 23189 23193 +4
- Partials 407 408 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Deploying with
|
| Latest commit: |
bbf495e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://032fd3a1.vald.pages.dev |
| Branch Preview URL: | https://refactor-add-helper-func-cal.vald.pages.dev |
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
kevindiu
force-pushed
the
refactor/add-helper-func-call
branch
from
487caed
to
9de6c54
Compare
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
This reverts commit 9de6c54.
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
kevindiu
changed the title
vankichi
approved these changes
Feb 1, 2023
This was referenced Feb 8, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kevindiu kevin_diu@yahoo.com.hk
Description:
This PR update
beforeFuncandafterFuncon the test to callt.Helper().It only update the function that is used, the code generated with old test template will not be updated when it is not using.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: