Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC status code for API docs #1943

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Feb 8, 2023

Signed-off-by: kevindiu kevin_diu@yahoo.com.hk

Description:

This PR updates the output gRPC status code of API doc.
It also updates the status table to describe the newly added status code: CANCELLED on docs/api/status.md.

Related Issue:

Versions:

  • Go Version: 1.20
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kevindiu kevindiu changed the title [WIP] Update gRPC status code for API docs Update gRPC status code for API docs Feb 8, 2023
@kevindiu kevindiu marked this pull request as ready for review February 8, 2023 08:25
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu merged commit bf5713f into main Feb 8, 2023
@kevindiu kevindiu deleted the documentation/update-grpc-status branch February 8, 2023 08:30
@kpango kpango mentioned this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants