-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test template to exclude deepsource warning #1954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
Deploying with Cloudflare Pages
|
kevindiu
changed the title
[WIP] Update test template
Update test template to exclude deepsource warning
Feb 27, 2023
kevindiu
requested review from
vankichi,
a team and
hlts2
and removed request for
a team
February 27, 2023 03:14
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: refactor/update-test-template-no-sync-field |
[REBASE] Failed to rebase. |
kevindiu
force-pushed
the
refactor/update-test-template-no-sync-field
branch
from
February 27, 2023 06:58
870a97a
to
16cb3aa
Compare
vankichi
previously approved these changes
Feb 28, 2023
vankichi
previously approved these changes
Mar 1, 2023
hlts2
previously approved these changes
Mar 3, 2023
kevindiu
force-pushed
the
refactor/update-test-template-no-sync-field
branch
from
March 3, 2023 01:47
529844b
to
7603233
Compare
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
kevindiu
force-pushed
the
refactor/update-test-template-no-sync-field
branch
from
March 3, 2023 01:54
7603233
to
6fd85f7
Compare
hlts2
approved these changes
Mar 3, 2023
vankichi
approved these changes
Mar 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR update the gotests test template to exclude the type on the generated test file.
These types are warned in deepsource before, including the following type:
Custom type exclusion will not be included in this PR.
You can verify this changes by using
make gotests/gen
command to generate the missing test impl and verify the changes usinggit diff [file]
.e.g.
git diff internal/circuitbreaker/manager_test.go
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: