Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[k8s]: Fix grafana dashboard query for backoff retry count #1961

Merged
merged 5 commits into from
Mar 6, 2023
Merged

[k8s]: Fix grafana dashboard query for backoff retry count #1961

merged 5 commits into from
Mar 6, 2023

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Mar 3, 2023 •
edited
Loading

Description:

Related Issue:

Versions:

  • Go Version: 1.20.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@hlts2
fix datasource prix for prometheus
3be076d 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
delete vald prefix for datasource uid
52bad04 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2
update backoff metrics query
4829745 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 changed the title Fix grafana dashboard query for [k8s]: Fix grafana dashboard query for backoff retry count Mar 3, 2023
@hlts2
Copy link
Collaborator Author

hlts2 commented Mar 3, 2023

The following is am image of the backoff_retry_count pannel.
We are able to get the number of backoffs for each rpc.
スクリーンショット 194

@hlts2 hlts2 self-assigned this Mar 3, 2023
@hlts2 hlts2 requested review from kpango and vankichi March 3, 2023 07:04
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 3, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

vankichi
vankichi previously approved these changes Mar 3, 2023
View reviewed changes
@hlts2
update writeout of pprof server
03f8fe9 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 3, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 83cc101
Status: ✅  Deploy successful!
Preview URL: https://0e6493c7.vald.pages.dev
Branch Preview URL: https://fix-k8s-fix-invalid-backoff-.vald.pages.dev

View logs

kpango
kpango approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi March 6, 2023 00:39
@hlts2 hlts2 marked this pull request as ready for review March 6, 2023 04:52
@hlts2 hlts2 merged commit 2f12824 into main Mar 6, 2023
@hlts2 hlts2 deleted the fix/k8s/fix-invalid-backoff-pannel branch March 6, 2023 07:09
@kpango kpango mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

Assignees

@hlts2 hlts2

Labels
area/helm priority/low size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kpango @vankichi