Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable balanced update features & use generic type for BidirectionalStream #1964

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Mar 7, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 7, 2023

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 7, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 0.62% and project coverage change: -0.05 ⚠️

Comparison is base (337a0fa) 29.70% compared to head (23a4663) 29.65%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
- Coverage   29.70%   29.65%   -0.05%     
==========================================
  Files         364      364              
  Lines       34130    34171      +41     
==========================================
- Hits        10138    10135       -3     
- Misses      23577    23620      +43     
- Partials      415      416       +1     
Impacted Files Coverage Δ
internal/config/grpc.go 86.33% <0.00%> (-1.64%) ⬇️
internal/net/grpc/stream.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/linear_search.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/handler/grpc/object.go 55.03% <0.00%> (+0.72%) ⬆️
pkg/agent/core/ngt/handler/grpc/remove.go 25.87% <0.00%> (+0.25%) ⬆️
pkg/agent/core/ngt/handler/grpc/search.go 23.10% <0.00%> (+0.19%) ⬆️
pkg/agent/core/ngt/handler/grpc/update.go 30.24% <0.00%> (+0.20%) ⬆️
pkg/agent/core/ngt/handler/grpc/upsert.go 29.92% <0.00%> (+0.21%) ⬆️
pkg/gateway/filter/handler/grpc/handler.go 0.00% <0.00%> (ø)
pkg/gateway/filter/usecase/vald.go 0.00% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the feature/gateway/disable-balanced-update branch from 0120116 to 2a2a5e0 Compare March 7, 2023 04:37
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 23a4663
Status: ✅  Deploy successful!
Preview URL: https://60f0aa3b.vald.pages.dev
Branch Preview URL: https://feature-gateway-disable-bala.vald.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango requested review from hlts2 and datelier March 7, 2023 05:21
datelier
datelier previously approved these changes Mar 7, 2023
hlts2
hlts2 previously approved these changes Mar 7, 2023
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…onalStream

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango dismissed stale reviews from hlts2 and datelier via 23a4663 March 8, 2023 01:08
@kpango kpango force-pushed the feature/gateway/disable-balanced-update branch from 2a2a5e0 to 23a4663 Compare March 8, 2023 01:08
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 8, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango merged commit d9b0176 into main Mar 8, 2023
@kpango kpango deleted the feature/gateway/disable-balanced-update branch March 8, 2023 03:14
@kpango kpango mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants