Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new API parameter and update observability docs #1966

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Add new API parameter and update observability docs #1966

merged 3 commits into from
Mar 10, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Mar 9, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vankichi vankichi requested review from kevindiu, a team and datelier and removed request for a team March 9, 2023 07:37
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Mar 9, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi
📝 add new API parameter and update o11y docs
7ae3264 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/docs/update-document branch from 6e21e55 to 7ae3264 Compare March 9, 2023 07:38
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 9, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c75089d
Status: ✅  Deploy successful!
Preview URL: https://ae8508a5.vald.pages.dev
Branch Preview URL: https://documentation-docs-update-do-7j34.vald.pages.dev

View logs

@vankichi vankichi requested a review from kevindiu March 9, 2023 07:47
@vankichi @kevindiu
Update docs/user-guides/observability-configuration.md
c75089d 
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi vankichi changed the title add new API parameter and update observability docs Add new API parameter and update observability docs Mar 10, 2023
@vankichi vankichi merged commit 8b95db1 into main Mar 10, 2023
@vankichi vankichi deleted the documentation/docs/update-document branch March 10, 2023 04:37
@kpango kpango mentioned this pull request Mar 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datelier datelier datelier approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @datelier