Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flg that can disable to ingress defaultBackend #1976

Merged
merged 20 commits into from
May 30, 2023
Merged

Added flg that can disable to ingress defaultBackend #1976

merged 20 commits into from
May 30, 2023

Conversation

takuyaymd
Copy link
Contributor

@takuyaymd takuyaymd commented Mar 13, 2023 •
edited
Loading

SSIA (vald-lb-gateway, vald-filter-gateway)

Description:

When running Vald with multiple Namespaces in the same Kubernetes cluster, I had to disable defaultBackend depending on the infrastructure situation, So I added a flag to disable defaultBackend.

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vankichi vankichi requested review from vankichi and hlts2 May 24, 2023 02:45
vankichi
vankichi reviewed May 24, 2023
View reviewed changes
charts/vald/values.yaml Outdated Show resolved Hide resolved
hlts2
hlts2 reviewed May 24, 2023
View reviewed changes
charts/vald/values.yaml Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented May 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@takuyaymd takuyaymd force-pushed the takuyaymd-feature/gateway-lb/add-default-backend-flag branch 2 times, most recently from 57da0e8 to 8caa994 Compare May 25, 2023 01:53
@takuyaymd takuyaymd changed the title Added flg that can disable to ingress defaultBackend [WIP]Added flg that can disable to ingress defaultBackend May 26, 2023
@takuyaymd takuyaymd changed the title [WIP]Added flg that can disable to ingress defaultBackend Support for advanced settings and disabling of DefaultBackend May 29, 2023
@takuyaymd takuyaymd changed the title Support for advanced settings and disabling of DefaultBackend Added flg that can disable to ingress defaultBackend May 30, 2023
vankichi
vankichi requested changes May 30, 2023
View reviewed changes
charts/vald/templates/gateway/filter/ing.yaml Outdated Show resolved Hide resolved
charts/vald/templates/gateway/lb/ing.yaml Outdated Show resolved Hide resolved
kpango
kpango approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 12e0bd9 into vdaas:main May 30, 2023
This was referenced Jun 12, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 left review comments

@kpango kpango kpango approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa ci/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@takuyaymd @CLAassistant @kpango @vankichi @hlts2