Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable gorules #1980

Merged
merged 1 commit into from
Mar 16, 2023
Merged

enable gorules #1980

merged 1 commit into from
Mar 16, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Mar 15, 2023 •
edited
Loading

Description:

Fix gorule test and CI path.

I noticed that @rinx had 👎 reaction in PR #1790, so I've fixed it.

Related Issue:

#1790

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango force-pushed the refactor/gorules/enable-gorules branch from 5321127 to b0e02f1 Compare March 15, 2023 09:11
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41dfc2d
Status: ✅  Deploy successful!
Preview URL: https://4aa161f6.vald.pages.dev
Branch Preview URL: https://refactor-gorules-enable-goru.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/gorules/enable-gorules branch 2 times, most recently from eeca9bf to f395a48 Compare March 15, 2023 09:26
@kpango kpango force-pushed the refactor/gorules/enable-gorules branch 7 times, most recently from e309c0d to b53da1e Compare March 15, 2023 10:33
@kpango
enable gorules
41dfc2d 
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the refactor/gorules/enable-gorules branch from b53da1e to 41dfc2d Compare March 15, 2023 10:39
hlts2
hlts2 approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango requested review from hlts2, rinx and datelier March 15, 2023 10:52
rinx
rinx approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kpango
Copy link
Collaborator Author

kpango commented Mar 16, 2023

@rinx Thank you for reviewing

@kpango kpango merged commit c140e40 into main Mar 16, 2023
@kpango kpango deleted the refactor/gorules/enable-gorules branch March 16, 2023 04:41
@vankichi vankichi mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rinx rinx rinx approved these changes

@hlts2 hlts2 hlts2 approved these changes

@datelier datelier datelier approved these changes

Assignees
No one assigned
Labels
area/makefile priority/low size/S team/set SET team team/sre SRE team type/ci type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpango @vdaas-ci @rinx @hlts2 @datelier