Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: fix range concurrency branch rule #1986

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Mar 29, 2023

Description:

I have fixed the concurrency branch rule at the internal/net/grpc/client.go.
Thanks to #1953 , the backoff problem is resolved.
However, the concurrency branch rule affects the lb service.
Ref: https://github.com/vdaas/vald/blob/main/pkg/gateway/lb/service/gateway.go#L72-L86

So, I have fixed it with @hlts2 and @kpango .

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7563389
Status: ✅  Deploy successful!
Preview URL: https://ac88c00a.vald.pages.dev
Branch Preview URL: https://bugfix-internal-fix-range-co.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added size/S type/bug Something isn't working priority/medium labels Mar 29, 2023
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (49ddfea) 29.61% compared to head (7563389) 29.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1986      +/-   ##
==========================================
- Coverage   29.61%   29.59%   -0.02%     
==========================================
  Files         365      365              
  Lines       34242    34245       +3     
==========================================
- Hits        10140    10136       -4     
- Misses      23683    23689       +6     
- Partials      419      420       +1     
Impacted Files Coverage Δ
internal/net/grpc/client.go 0.00% <0.00%> (ø)
internal/net/grpc/context.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vankichi vankichi merged commit 48e14c1 into main Mar 29, 2023
@vankichi vankichi deleted the bugfix/internal/fix-range-concurrency-branch-rule branch March 29, 2023 07:55
@vankichi vankichi mentioned this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants