Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output error log to ChatOpts comment #1999

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Apr 6, 2023

Description:

This PR include the following changes:

  • Output error to chatops comment if /gen-test command failed
  • Fix /gen-test chatops command failure

Related Issue:

Versions:

  • Go Version: 1.20.2
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

I have tested the command on my local PC but for the CI to pass the error message to another step, I am not sure if it works or not since the changes will not be effective before this PR is merged.

@kevindiu
Copy link
Contributor Author

kevindiu commented Apr 6, 2023

/gen-test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 6, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 6, 2023

[GEN TEST] Generating missing test files triggered by kevindiu.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 6, 2023

[GEN TEST] Failed to generate tests.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cf43421
Status: ✅  Deploy successful!
Preview URL: https://5fe104de.vald.pages.dev
Branch Preview URL: https://test-create-test-with-placeh.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Apr 6, 2023

[GEN TEST] Failed to generate tests.

@kevindiu kevindiu marked this pull request as ready for review April 6, 2023 08:32
@kevindiu kevindiu changed the title [WIP] Create empty test with placeholder using ChatOpts Output error log to ChatOpts comment Apr 6, 2023
@kevindiu kevindiu requested review from vankichi and hlts2 April 6, 2023 08:33
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu force-pushed the test/create-test-with-placeholder branch from 5ec4494 to cf43421 Compare April 7, 2023 06:50
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@kevindiu kevindiu merged commit f6cfee4 into main Apr 7, 2023
@kevindiu kevindiu deleted the test/create-test-with-placeholder branch April 7, 2023 07:36
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants