Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI chatops format workflow #2007

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

vankichi
Copy link
Contributor

Description:

I have fixed the format (chatops) workflow.
make license should be run before make format/go to format all files, but the current workflow runs make license after make format/go.
So, I have fixed this issue in this PR.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kpango
kpango previously approved these changes Apr 13, 2023
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Apr 13, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d7024d
Status: ✅  Deploy successful!
Preview URL: https://039253de.vald.pages.dev
Branch Preview URL: https://ci-workflows-fix-format-chat.vald.pages.dev

View logs

@vankichi vankichi merged commit e8d40c4 into main Apr 13, 2023
@vankichi vankichi deleted the ci/workflows/fix-format-chatops-workflow branch April 13, 2023 06:29
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants