Implement generic function tests #2008

kevindiu · 2023-04-13T08:32:58Z

Description:

This PR implemented the generic function tests removed in this commit.
baf038d

Related Issue:

Versions:

Go Version: 1.20.3
Docker Version: 20.10.8
Kubernetes Version: 1.22.0
NGT Version: 2.0.9

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

vdaas-ci · 2023-04-13T08:33:18Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kevindiu · 2023-04-13T08:35:03Z

internal/test/mock/server_stream.go

@@ -17,7 +17,7 @@ import (
 	"context"

 	"github.com/vdaas/vald/apis/grpc/v1/payload"
-	"github.com/vdaas/vald/internal/net/grpc"


to fix cycle import

kevindiu · 2023-04-13T08:41:08Z

/gen-test
/format

vdaas-ci · 2023-04-13T08:41:55Z

[GEN TEST] Generating missing test files triggered by kevindiu.

internal/slices/slices_test.go

sonatype-lift · 2023-04-13T08:42:29Z

internal/slices/slices_test.go

+	type want struct {
+		want []int
+	}
+	type test struct {


govet: fieldalignment: struct with 88 pointer bytes could be 72

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

sonatype-lift · 2023-04-13T08:42:31Z

internal/slices/slices_test.go

+}
+
+func TestSortFunc(t *testing.T) {
+	type args struct {


govet: fieldalignment: struct with 32 pointer bytes could be 16

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

Help us improve LIFT! (Sonatype LiftBot external survey)

Was this a good recommendation for you? _{Answering this survey will not impact your Lift settings.}

[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]

vdaas-ci · 2023-04-13T08:45:37Z

[GEN TEST] Generating missing test files triggered by kevindiu.

internal/slices/slices_test.go

github-actions · 2023-04-13T09:01:54Z

internal/net/grpc/stream_test.go

+
+						obj := i.(*payload.Insert_Request)
+						if insertReqs[recvIdx] != nil {
+							obj.Vector = insertReqs[recvIdx].Vector


🚫 [golangci] _{reported by reviewdog 🐶}
ruleguard: Avoid to access struct fields directly (gocritic)

codecov · 2023-04-13T09:09:43Z

Codecov Report

Patch coverage has no change and project coverage change: +0.11 🎉

Comparison is base (d7c6bd3) 29.36% compared to head (5fac1d9) 29.48%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2008      +/-   ##
==========================================
+ Coverage   29.36%   29.48%   +0.11%     
==========================================
  Files         366      366              
  Lines       34532    34532              
==========================================
+ Hits        10141    10182      +41     
+ Misses      23972    23926      -46     
- Partials      419      424       +5

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cloudflare-workers-and-pages · 2023-04-14T04:18:03Z

Deploying with Cloudflare Pages

Latest commit:	`5fac1d9`
Status:	✅ Deploy successful!
Preview URL:	https://72e10972.vald.pages.dev
Branch Preview URL:	https://test-impl-generic-tests.vald.pages.dev

View logs

kevindiu · 2023-04-14T09:12:39Z

/gen-test
/format

vdaas-ci · 2023-04-14T09:13:24Z

[GEN TEST] Generating missing test files triggered by kevindiu.

vdaas-ci · 2023-04-14T09:19:40Z

[GEN TEST] Generating missing test files triggered by kevindiu.

kevindiu · 2023-04-17T01:17:52Z

/gen-test

vdaas-ci · 2023-04-17T01:18:49Z

[GEN TEST] Generating missing test files triggered by kevindiu.

kevindiu · 2023-04-17T03:34:47Z

/gen-test

vdaas-ci · 2023-04-17T03:35:35Z

[GEN TEST] Generating missing test files triggered by kevindiu.

vdaas-ci · 2023-04-17T03:35:42Z

[GEN TEST] Failed to generate tests. Error:

vdaas-ci · 2023-04-17T04:28:35Z

[GEN TEST] Generating missing test files triggered by kevindiu.

internal/net/grpc/stream_test.go

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>

internal/net/grpc/stream_test.go

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

hlts2

LGTM

vankichi

LGTM

github-actions · 2023-04-19T01:47:45Z

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/test%2Fimpl-generic-tests/c7a62e141ab704977fae6552697ba68fda763e9d

vdaas-ci · 2023-04-19T01:55:39Z

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

github-actions bot added area/internal team/set SET team size/L type/test Adding tests labels Apr 13, 2023

kevindiu changed the title ~~Implement generic tests~~ Implement generic function tests Apr 13, 2023

kevindiu changed the title ~~Implement generic function tests~~ [WIP] Implement generic function tests Apr 13, 2023

github-actions bot added the priority/low label Apr 13, 2023

kevindiu commented Apr 13, 2023

View reviewed changes

sonatype-lift bot reviewed Apr 13, 2023

View reviewed changes

internal/slices/slices_test.go Outdated Show resolved Hide resolved

sonatype-lift bot reviewed Apr 13, 2023

View reviewed changes

kevindiu requested review from vankichi, a team and hlts2 and removed request for a team April 13, 2023 08:44

github-actions bot reviewed Apr 13, 2023

View reviewed changes

kpango changed the title ~~[WIP] Implement generic function tests~~ Implement generic function tests Apr 18, 2023

kpango marked this pull request as ready for review April 18, 2023 05:15

vankichi requested changes Apr 18, 2023

View reviewed changes

internal/net/grpc/stream_test.go Outdated Show resolved Hide resolved

internal/net/grpc/stream_test.go Outdated Show resolved Hide resolved

internal/net/grpc/stream_test.go Outdated Show resolved Hide resolved

kevindiu requested a review from vankichi April 18, 2023 06:59

kevindiu and others added 6 commits April 18, 2023 16:53

impl test

562557e

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>

Update internal/slices/slices_test.go

862f6dc

style: Format code with prettier and gofumpt

9491770

fix compile error

67be4b6

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>

Apply suggestions from code review

af0ff5e

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

fix comment

7786ab9

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>

kevindiu force-pushed the test/impl-generic-tests branch from 0522ed8 to 7786ab9 Compare April 18, 2023 07:53

hlts2 reviewed Apr 18, 2023

View reviewed changes

internal/net/grpc/stream_test.go Outdated Show resolved Hide resolved

Update internal/net/grpc/stream_test.go

ad90ef9

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

kevindiu requested a review from hlts2 April 18, 2023 08:05

hlts2 approved these changes Apr 18, 2023

View reviewed changes

vankichi approved these changes Apr 18, 2023

View reviewed changes

Merge branch 'main' into test/impl-generic-tests

5fac1d9

vankichi added actions/e2e-deploy actions/fossa actions/e2e-chaos actions/e2e-profiling labels Apr 19, 2023

vankichi merged commit 540c93a into main Apr 19, 2023

vankichi deleted the test/impl-generic-tests branch April 19, 2023 02:30

ykadowak mentioned this pull request Apr 24, 2023

[patch] release v1.7.5 #2013

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement generic function tests #2008

Implement generic function tests #2008

kevindiu commented Apr 13, 2023 •

edited

Loading

vdaas-ci commented Apr 13, 2023

kevindiu Apr 13, 2023

kevindiu commented Apr 13, 2023

vdaas-ci commented Apr 13, 2023

sonatype-lift bot Apr 13, 2023

sonatype-lift bot Apr 13, 2023

vdaas-ci commented Apr 13, 2023

github-actions bot Apr 13, 2023

codecov bot commented Apr 13, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 14, 2023 •

edited

Loading

kevindiu commented Apr 14, 2023

vdaas-ci commented Apr 14, 2023

vdaas-ci commented Apr 14, 2023

kevindiu commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

kevindiu commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

hlts2 left a comment

vankichi left a comment

github-actions bot commented Apr 19, 2023

vdaas-ci commented Apr 19, 2023

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Implement generic function tests #2008

Implement generic function tests #2008

Conversation

kevindiu commented Apr 13, 2023 • edited Loading

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

vdaas-ci commented Apr 13, 2023

kevindiu Apr 13, 2023

Choose a reason for hiding this comment

kevindiu commented Apr 13, 2023

vdaas-ci commented Apr 13, 2023

sonatype-lift bot Apr 13, 2023

Choose a reason for hiding this comment

sonatype-lift bot Apr 13, 2023

Choose a reason for hiding this comment

vdaas-ci commented Apr 13, 2023

github-actions bot Apr 13, 2023

Choose a reason for hiding this comment

codecov bot commented Apr 13, 2023 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Apr 14, 2023 • edited Loading

Deploying with Cloudflare Pages

kevindiu commented Apr 14, 2023

vdaas-ci commented Apr 14, 2023

vdaas-ci commented Apr 14, 2023

kevindiu commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

kevindiu commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

vdaas-ci commented Apr 17, 2023

hlts2 left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

github-actions bot commented Apr 19, 2023

vdaas-ci commented Apr 19, 2023

Profile Report

kevindiu commented Apr 13, 2023 •

edited

Loading

codecov bot commented Apr 13, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 14, 2023 •

edited

Loading