[bugfix] Correction of a bug that returned NotFound as success 0 when balancedUpdate is disabled and all ReplicaAgents returned AlreadyExists (already have the exact same Index).

[kpango]

Description:

Correction of a bug that returned NotFound as success 0 when balancedUpdate is disabled and all ReplicaAgents returned AlreadyExists (already have the exact same Index).

Changes:

1. Add error handling for all replica returns AlreadyExists.
2. Add re-Insert process when detected index replica shortage.

API starus befor and after:
Before

• AlreadyExists count == 0 && location is empty -> NotFound
• AlreadyExists count == Replica -> NotFound
• AlreadyExists and Success -> Success

After

• AlreadyExists count == 0 && location is empty -> NotFound
• AlreadyExists count == Replica -> AlreadyExists
• AlreadyExists and Success -> Success

Related Issue:

Versions:

• Go Version: 1.20.3
• Docker Version: 20.10.8
• Kubernetes Version: 1.22.0
• NGT Version: 2.0.9

Checklist:

• I have read the CONTRIBUTING document and completed our CLA agreement.
• I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - replace the PR body by changelog details
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase main
• 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	01117f2
Status:	✅  Deploy successful!
Preview URL:	https://63c1a43c.vald.pages.dev
Branch Preview URL:	https://bugfix-lb-disable-balanced-u.vald.pages.dev

View logs

[github-actions]

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Flb%2Fdisable-balanced-update-error-handling/ca3be6d5b901164b58d55f45d74561c8739d2395

[vdaas-ci]

Profile Report

type	vald-agent-ngt	vald-lb-gateway	vald-discoverer	vald-manager-index
cpu
heap

other images

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.06 ⚠️

Comparison is base (538fbee) 29.48% compared to head (01117f2) 29.42%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2011      +/-   ##
==========================================
- Coverage   29.48%   29.42%   -0.06%     
==========================================
  Files         366      366              
  Lines       34559    34625      +66     
==========================================
+ Hits        10188    10189       +1     
- Misses      23943    24010      +67     
+ Partials      428      426       -2     

Impacted Files	Coverage Δ
pkg/gateway/lb/handler/grpc/handler.go	0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.