fixed duplicate counting in CPU graphs #2019
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
CPU resource graph on each dashboard was summing pod-wide metrics and metrics for each container, causing the graph to count approximately twice as much.
This fix adds
image!=""
, and only container totals will be counted.Related Issue:
Versions:
Checklist:
Special notes for your reviewer:
(Suggestion) These queries set
container="${Replicaset}"
, so if users insert their own sidecar containers, they will not be able to see the exact resource for the entire POD.I believe the workaround is to either remove the
container
specification and replace it withimage=""
or allow the user to select thecontainer
aggregate on the dashboard.