Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed duplicate counting in CPU graphs #2019

Merged

Conversation

takuyaymd
Copy link
Contributor

@takuyaymd takuyaymd commented Apr 26, 2023

Description:

CPU resource graph on each dashboard was summing pod-wide metrics and metrics for each container, causing the graph to count approximately twice as much.
This fix adds image!="", and only container totals will be counted.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

(Suggestion) These queries set container="${Replicaset}", so if users insert their own sidecar containers, they will not be able to see the exact resource for the entire POD.
I believe the workaround is to either remove the container specification and replace it with image="" or allow the user to select the container aggregate on the dashboard.

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍

@kpango
Copy link
Collaborator

kpango commented Apr 26, 2023

@all-contributors please add @takuyaymd for maintenance

@allcontributors
Copy link
Contributor

@kpango

I've put up a pull request to add @takuyaymd! 🎉

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit a83737b into vdaas:main Apr 26, 2023
@takuyaymd takuyaymd deleted the bugfix/dashboard/fix-cpu-duplicate-count branch May 22, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants