Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix E2E actions on PR #2025

Merged
merged 6 commits into from
May 11, 2023
Merged

Fix E2E actions on PR #2025

merged 6 commits into from
May 11, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented May 10, 2023 •
edited
Loading

Description:

This PR partially fixes the regression of #2024 that all the e2e actions fail. With this PR, e2e actions work correctly except for actions/e2e-max-dim.

Fixed three things,

  1. Wrong usage of outputs
  2. Output accurate POD_NAME
  3. Allow empty resources when executing kubectl apply

There will be another PR for actions/e2e-max-dim.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 10, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1903f4e
Status: ✅  Deploy successful!
Preview URL: https://1597a203.vald.pages.dev
Branch Preview URL: https://ci-helm-check-e2e-on-pr.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

1 similar comment
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@ykadowak ykadowak changed the title [WIP] Test if the local charts are used on PR Fix E2E actions on PR May 11, 2023
@ykadowak ykadowak requested review from kpango and hlts2 May 11, 2023 03:30
hlts2
hlts2 approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kpango
kpango approved these changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit e911e4c into main May 11, 2023
@kpango kpango deleted the ci/helm/check-e2e-on-pr branch May 11, 2023 06:28
@ykadowak ykadowak mentioned this pull request May 17, 2023
Merged
2 tasks
This was referenced Jun 12, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlts2 hlts2 hlts2 approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/makefile priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @hlts2