Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker Build workflow with forked sources #2036

Merged
merged 2 commits into from
May 23, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented May 23, 2023

Description:

I have updated the GitHub workflows, which contain pull_request_target.

It is because if the PR whose base branch is the forked repository, the current workflow cannot build a new docker image with the forked repositories' source code.
So, I changed workflows as followings;

  1. Getting SHA before actions/checkout
  2. Setting it to the ref parameter in the actions/checkout step.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

You can see the new workflow on #2035

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi force-pushed the ci/workflows/allow-docker-build-with-forked-repo-sources branch from f9fd3c3 to 07f5d4c Compare May 23, 2023 04:40
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b4ebe39
Status: ✅  Deploy successful!
Preview URL: https://192cc25d.vald.pages.dev
Branch Preview URL: https://ci-workflows-allow-docker-bu.vald.pages.dev

View logs

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the ci/workflows/allow-docker-build-with-forked-repo-sources branch from 07f5d4c to 69d5e9a Compare May 23, 2023 07:11
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi requested review from a team, kevindiu, datelier and kpango and removed request for a team and kevindiu May 23, 2023 07:50
@vankichi vankichi marked this pull request as ready for review May 23, 2023 07:50
@vankichi vankichi changed the title [WIP] Update Docker Build workflow with forked sources Update Docker Build workflow with forked sources May 23, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 78a83b0 into main May 23, 2023
@kpango kpango deleted the ci/workflows/allow-docker-build-with-forked-repo-sources branch May 23, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants