Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable deepsource TestCoverage due to the Deepsource Coverage collect server timeout is too short for Vald testing #2038

Merged
merged 1 commit into from
May 24, 2023
Merged

disable deepsource TestCoverage due to the Deepsource Coverage collect server timeout is too short for Vald testing #2038

merged 1 commit into from
May 24, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented May 24, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@kpango
disable deepsource TestCoverage due to the Deepsource Coverage collec…
877e8e6 
…t server timeout is too short for Vald testing

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango mentioned this pull request May 24, 2023
Merged
2 tasks
ykadowak
ykadowak approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@ykadowak ykadowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels good to see the CI is not failing

@kpango kpango requested review from a team, kevindiu and datelier and removed request for a team May 24, 2023 02:37
@kpango kpango merged commit 7dd8273 into main May 24, 2023
@kpango kpango deleted the ci/deepsource/disable-test-coverage branch May 24, 2023 02:44
This was referenced Jun 12, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

@kevindiu kevindiu kevindiu approved these changes

@datelier datelier Awaiting requested review from datelier datelier was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
priority/low size/S type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kevindiu @ykadowak