[bugfix] fp16 problems #2049
Merged
[bugfix] fp16 problems #2049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/internal
size/M
type/bug
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2049 +/- ##
==========================================
- Coverage 29.99% 28.78% -1.21%
==========================================
Files 366 344 -22
Lines 34797 30015 -4782
==========================================
- Hits 10436 8641 -1795
+ Misses 23878 21085 -2793
+ Partials 483 289 -194
☔ View full report in Codecov by Sentry. |
Deploying with
|
| Latest commit: |
d7ce12e
|
| Status: | ⚡️ Build in progress... |
kpango
force-pushed
the
bugfix/internal-core-ngt/fix-fp16-problems
branch
2 times, most recently
from
cc63a73
to
a1e6788
Compare
kpango
force-pushed
the
bugfix/internal-core-ngt/fix-fp16-problems
branch
4 times, most recently
from
621e6cb
to
43a0234
Compare
Signed-off-by: kpango <kpango@vdaas.org>
kpango
force-pushed
the
bugfix/internal-core-ngt/fix-fp16-problems
branch
from
43a0234
to
829bb4c
Compare
datelier
approved these changes
Jun 9, 2023
ykadowak
reviewed
Jun 9, 2023
Comment on lines
+137
to
+140
| fmt.Println("r, t: ", r[i], t[i]) | ||
| sum += math.Pow(float64(t[i]-r[i]), 2) | ||
| } | ||
| fmt.Println(sum) |
There was a problem hiding this comment.
Probably should refactor these prints
hlts2
approved these changes
Jun 9, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
he current vald implementation cannot correctly handle GetObject RPCs because the Go language does not support half-precision floating point.
The next version of NGT will include a new CAPI that can correctly get fp16 arrays as float arrays.
So I've implemented it and Updated NGT version to 2.0.12
Related Issue:
#1781
Versions:
Checklist:
Special notes for your reviewer: