Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] disable vtproto pooling due to the performance degradation #2063

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 14, 2023

Description:

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 14, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 719433c
Status: ✅  Deploy successful!
Preview URL: https://4ef54bc2.vald.pages.dev
Branch Preview URL: https://bugfix-vtpool-disable-poolin.vald.pages.dev

View logs

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage: 41.37% and project coverage change: +0.02 🎉

Comparison is base (02927a3) 29.94% compared to head (719433c) 29.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
+ Coverage   29.94%   29.96%   +0.02%     
==========================================
  Files         369      369              
  Lines       35092    35046      -46     
==========================================
- Hits        10507    10502       -5     
+ Misses      24104    24064      -40     
+ Partials      481      480       -1     
Impacted Files Coverage Δ
internal/net/grpc/client.go 0.00% <0.00%> (ø)
pkg/discoverer/k8s/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/net/grpc/codec.go 77.77% <75.00%> (+5.05%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the bugfix/vtpool/disable-pooling branch from 7287a27 to 0912504 Compare June 14, 2023 08:38
@github-actions github-actions bot added team/set SET team size/XXL and removed size/L labels Jun 14, 2023
@kpango kpango force-pushed the bugfix/vtpool/disable-pooling branch from 0912504 to 719e571 Compare June 14, 2023 09:02
@kpango kpango force-pushed the bugfix/vtpool/disable-pooling branch from 719e571 to 719433c Compare June 14, 2023 09:42
@kpango kpango changed the title [DO NOT MERGE] [bugfix] disable vtproto pooling due to the performance degradation [bugfix] disable vtproto pooling due to the performance degradation Jun 14, 2023
@kpango kpango marked this pull request as ready for review June 14, 2023 09:42
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kmrmt kmrmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango merged commit 407e6f5 into main Jun 15, 2023
@kpango kpango deleted the bugfix/vtpool/disable-pooling branch June 15, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants