Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix non-trusted module problem of v1.7.6 and disable not found debug message #2076

Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jun 15, 2023

Description:

Bugfix: v1.7.6 was frequently re-released, and it was found that wrarning occurred in trust as go module, so I set GOPRIVATE for each command and refactored CI and Makefile at the same time.

Refactor: The error logs of Empty response and RequestCancel at the time of BroadCast search to Agents have been suppressed.

WARN: The release of v1.7.7 should be considered after this PR merge.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (407e6f5) 29.94% compared to head (082b1d4) 29.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2076      +/-   ##
==========================================
- Coverage   29.94%   29.94%   -0.01%     
==========================================
  Files         369      369              
  Lines       35046    35048       +2     
==========================================
  Hits        10495    10495              
- Misses      24070    24072       +2     
  Partials      481      481              
Impacted Files Coverage Δ
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from d4c500f to a6bd488 Compare June 20, 2023 02:09
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 082b1d4
Status: ✅  Deploy successful!
Preview URL: https://6d1cf4c9.vald.pages.dev
Branch Preview URL: https://refactor-disable-not-found-d.vald.pages.dev

View logs

@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from a6bd488 to 6beb022 Compare June 20, 2023 02:31
@github-actions github-actions bot added size/L and removed size/S labels Jun 20, 2023
@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from 6beb022 to 02704b3 Compare June 20, 2023 03:38
@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from 02704b3 to 3b65ad9 Compare June 20, 2023 04:32
@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch 2 times, most recently from 37b46ba to f21410c Compare June 20, 2023 04:49
@github-actions github-actions bot added the team/set SET team label Jun 20, 2023
@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from f21410c to 57e9ccd Compare June 20, 2023 04:58
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango force-pushed the refactor/disable/not-found-debug-message-for-aggregation branch from 57e9ccd to 48fe460 Compare June 20, 2023 05:21
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

…message

Signed-off-by: kpango <kpango@vdaas.org>
@github-actions
Copy link
Contributor

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@kpango kpango requested review from a team, vankichi and hlts2 and removed request for a team June 23, 2023 00:12
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 85ad070 into main Jun 23, 2023
@kpango kpango deleted the refactor/disable/not-found-debug-message-for-aggregation branch June 23, 2023 06:09
ykadowak pushed a commit that referenced this pull request Jun 26, 2023
…message (#2076)

Signed-off-by: kpango <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants