Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs: search API and client API config #2081

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

vankichi
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi requested review from kpango, a team and datelier and removed request for a team June 19, 2023 08:54
docs/api/search.md Show resolved Hide resolved
docs/api/search.md Show resolved Hide resolved
docs/api/search.md Show resolved Hide resolved
docs/api/search.md Show resolved Hide resolved
docs/user-guides/client-api-config.md Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/api/search.md Outdated Show resolved Hide resolved
docs/user-guides/client-api-config.md Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4d6bc72
Status: ✅  Deploy successful!
Preview URL: https://dd054a04.vald.pages.dev
Branch Preview URL: https://documentation-docs-update-ap.vald.pages.dev

View logs

@vankichi vankichi requested a review from kpango June 20, 2023 08:08
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi and others added 2 commits June 22, 2023 10:14
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
@vankichi vankichi force-pushed the documentation/docs/update-api-config branch from 67d1d76 to 4d6bc72 Compare June 22, 2023 01:14
@vankichi vankichi merged commit db06e2f into main Jun 22, 2023
@vankichi vankichi deleted the documentation/docs/update-api-config branch June 22, 2023 07:24
ykadowak pushed a commit that referenced this pull request Jun 26, 2023
* 📝 Update docs: search API and client API config

Signed-off-by: vankichi <kyukawa315@gmail.com>

* Apply suggestions from code review

Co-authored-by: Yusuke Kato <kpango@vdaas.org>

---------

Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants