-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "make gotests/gen" command #2085
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CHATOPS:HELP] ChatOps commands.
|
Deploying with Cloudflare Pages
|
kevindiu
force-pushed
the
ci/update-gen-test-command
branch
from
June 21, 2023 08:42
5efc35c
to
fd9c170
Compare
kevindiu
requested review from
a team,
kmrmt and
datelier
and removed request for
a team
June 21, 2023 09:49
kevindiu
changed the title
[WIP] Update "make gotests/gen" command
Update "make gotests/gen" command
Jun 22, 2023
kmrmt
previously approved these changes
Jun 23, 2023
kmrmt
approved these changes
Jun 28, 2023
datelier
approved these changes
Jun 28, 2023
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: Vdaas CI <vald@vdaas.org>
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
This reverts commit d58682f.
kevindiu
force-pushed
the
ci/update-gen-test-command
branch
from
June 28, 2023 05:55
38bf134
to
e7b6cfd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
make gotests/gen
command with the following update:New()
test case inpkg/*/usecase
packagepkg/*/router
,pkg/*/handler/rest
packagepkg
packageNOT IMPLEMENTED BELOW
placeholder/gen-test
ChatOpts errorRelated Issue:
Versions:
Checklist:
Special notes for your reviewer:
Since the changes of the ChatOpts does not have any affect before the PR is merged, we need to create another PR to test it later.