Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fix url http to https #2090

Merged
merged 3 commits into from
Jun 29, 2023
Merged

Refactor fix url http to https #2090

merged 3 commits into from
Jun 29, 2023

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Jun 26, 2023 •
edited
Loading

Description:

I basically refactored url schema http to https.
Not fixed if any of the following reasons apply:

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kmrmt kmrmt force-pushed the refactor/fix-url-http-to-https branch from e35a688 to 4edb355 Compare June 27, 2023 05:31
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 27, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7a76932
Status: ✅  Deploy successful!
Preview URL: https://f4651b6e.vald.pages.dev
Branch Preview URL: https://refactor-fix-url-http-to-htt.vald.pages.dev

View logs

@kmrmt kmrmt force-pushed the refactor/fix-url-http-to-https branch from 4edb355 to 15e3621 Compare June 27, 2023 10:55
@kmrmt
fix url to https
6204680 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix url to https manually
33ed2ae 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt force-pushed the refactor/fix-url-http-to-https branch from 15e3621 to 33ed2ae Compare June 28, 2023 06:05
@kmrmt kmrmt requested review from a team, vankichi and datelier and removed request for a team June 28, 2023 06:05
@vankichi
Copy link
Contributor

LGTM. Please rebase branch.

kpango
kpango approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 5a9c8ef into main Jun 29, 2023
@kpango kpango deleted the refactor/fix-url-http-to-https branch June 29, 2023 08:52
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Refactor fix url http to https (#2090)"
1f502a8 
This reverts commit 5a9c8ef.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

@datelier datelier Awaiting requested review from datelier datelier was automatically assigned from vdaas/maintainer

Assignees
No one assigned
Labels
area/helm area/makefile priority/low size/S team/sre SRE team type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmrmt @vdaas-ci @vankichi @kpango