Add backup origin when CoW enabled and failed to load primary #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/agent/core
team/set
Deploying with
|
| Latest commit: |
6e2a17b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f3f0e23.vald.pages.dev |
| Branch Preview URL: | https://feature-agent-add-backup-ori.vald.pages.dev |
ykadowak
changed the title
ykadowak
requested review from
a team,
kevindiu and
kpango
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
==========================================
- Coverage 29.96% 29.94% -0.02%
==========================================
Files 369 369
Lines 35083 35086 +3
==========================================
- Hits 10511 10505 -6
- Misses 24089 24099 +10
+ Partials 483 482 -1
☔ View full report in Codecov by Sentry. |
vankichi
requested review from
a team and
kmrmt
and removed request for
kevindiu and
a team
kpango
requested changes
Jun 27, 2023
kmrmt
approved these changes
Jun 28, 2023
vankichi
force-pushed
the
feature/agent/add-backup-origin-case-when-cow-enabled
branch
from
4448b13
to
4e20e17
Compare
ykadowak
force-pushed
the
feature/agent/add-backup-origin-case-when-cow-enabled
branch
from
4e20e17
to
6e2a17b
Compare
vankichi
deleted the
feature/agent/add-backup-origin-case-when-cow-enabled
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With this PR, the primary index will be backed up immediately when the agent fails to load it with CoW enabled. Before, it was backed up only when it fails to load both primary and old index.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: