Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install additional tools for docker image for devcontainer #2101

Merged
merged 10 commits into from
Jul 4, 2023
Merged

Install additional tools for docker image for devcontainer #2101

merged 10 commits into from
Jul 4, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Jun 30, 2023 •
edited
Loading

Description:

  • Change to login to devcontainer with root user for simplicity
  • Run go/deps in Dockerfile to install tools
  • Refactor things

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 30, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca6ca3e
Status: ✅  Deploy successful!
Preview URL: https://0ede96b1.vald.pages.dev
Branch Preview URL: https://feature-dockers-devcontainer.vald.pages.dev

View logs

@ykadowak ykadowak force-pushed the feature/dockers/devcontainer-install-tools branch from 69cdb7a to 98a93e3 Compare June 30, 2023 05:53
@ykadowak ykadowak changed the title Install additional tools for docker image for devcontainer [WIP] Install additional tools for docker image for devcontainer Jun 30, 2023
@github-actions github-actions bot added size/M and removed size/S labels Jun 30, 2023
@ykadowak ykadowak changed the title [WIP] Install additional tools for docker image for devcontainer Install additional tools for docker image for devcontainer Jun 30, 2023
kpango
kpango previously approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ykadowak ykadowak requested review from kpango, a team and datelier and removed request for a team July 3, 2023 05:16
@ykadowak ykadowak merged commit 10506e5 into main Jul 4, 2023
@ykadowak ykadowak deleted the feature/dockers/devcontainer-install-tools branch July 4, 2023 03:42
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Install additional tools for docker image for devcontainer (#…
f279c0c 
…2101)"

This reverts commit 10506e5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datelier datelier datelier approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
area/makefile priority/medium size/M team/sre SRE team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @datelier