Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update golangci-lint configuration: use white-list configuration pattern #2106

Merged
merged 2 commits into from
Jul 7, 2023
Merged

update golangci-lint configuration: use white-list configuration pattern #2106

merged 2 commits into from
Jul 7, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jul 4, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aec88e4
Status: ✅  Deploy successful!
Preview URL: https://2403d785.vald.pages.dev
Branch Preview URL: https://refactor-tools-golangci-lint.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 4, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi requested review from a team, kmrmt and ykadowak and removed request for a team July 4, 2023 05:27
@ykadowak ykadowak merged commit 332afd0 into main Jul 7, 2023
@ykadowak ykadowak deleted the refactor/tools/golangci-lint-config branch July 7, 2023 04:19
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "update golangci-lint configuration: use white-list configurat…
6df7788 
…ion pattern (#2106)"

This reverts commit 332afd0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

@kmrmt kmrmt kmrmt approved these changes

Assignees
No one assigned
Labels
priority/low size/S type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kpango @vdaas-ci @kmrmt @ykadowak