Re-Generate test codes #2107

kpango · 2023-07-04T10:10:21Z

Description:

SSIA

Related Issue:

Versions:

Go Version: 1.20.5
Docker Version: 20.10.8
Kubernetes Version: v1.27.3
NGT Version: 2.0.13

Checklist:

I have read the CONTRIBUTING document and completed our CLA agreement.
I have checked open Pull Requests for the similar feature or fixes?

Special notes for your reviewer:

vdaas-ci · 2023-07-04T10:10:40Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - replace the PR body by changelog details
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase main
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

sonatype-lift · 2023-07-04T10:29:03Z

cmd/tools/cli/vdctl/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		want       want


dupword: Duplicate words (want) found

❗❗ 8 similar findings have been found in this PR

🔎 Expand here to view all instances of this finding

File Path Line Number

internal/conv/conv_test.go 397

internal/conv/conv_test.go 398

internal/log/mock/logger_test.go 852

internal/log/mock/logger_test.go 853

internal/log/mock/logger_test.go 854

internal/log/mock/logger_test.go 985

internal/log/mock/logger_test.go 986

internal/log/mock/logger_test.go 1119

Visit the Lift Web Console to find more details in your report.

ℹ️ Expand to see all @sonatype-lift commands

You can reply with the following commands. For example, reply with @sonatype-lift ignoreall to leave out all findings.

Command Usage

@sonatype-lift ignore Leave out the above finding from this PR

@sonatype-lift ignoreall Leave out all the existing findings from this PR

@sonatype-lift exclude <file|issue|path|tool> Exclude specified file|issue|path|tool from Lift findings by updating your config.toml file

Note: When talking to LiftBot, you need to refresh the page to see its response.
_{Click here to add LiftBot to another repo.}

github-actions · 2023-07-04T10:43:14Z

cmd/agent/core/ngt/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		want       want


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (want) found (dupword)

github-actions · 2023-07-04T10:43:14Z

cmd/agent/sidecar/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		want       want


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (want) found (dupword)

github-actions · 2023-07-04T10:43:14Z

cmd/discoverer/k8s/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		want       want


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (want) found (dupword)

github-actions · 2023-07-04T10:43:14Z

hack/helm/schema/crd/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		args       args


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (args) found (dupword)

github-actions · 2023-07-04T10:43:15Z

hack/helm/schema/crd/main_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		args       args


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (args) found (dupword)

github-actions · 2023-07-04T10:43:15Z

internal/circuitbreaker/breaker_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		fields     fields


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (fields) found (dupword)

github-actions · 2023-07-04T10:43:15Z

internal/circuitbreaker/breaker_test.go

+// 	}
+// 	type test struct {
+// 		name       string
+// 		fields     fields


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (fields) found (dupword)

github-actions · 2023-07-04T10:43:16Z

pkg/manager/index/service/indexer_test.go

+// 		saveIndexWaitDuration  time.Duration
+// 		saveIndexTargetAddrCh  chan string
+// 		concurrency            int
+// 		indexInfos             indexInfos


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (indexInfos) found (dupword)

github-actions · 2023-07-04T10:43:16Z

pkg/manager/index/service/indexer_test.go

+// 		saveIndexWaitDuration  time.Duration
+// 		saveIndexTargetAddrCh  chan string
+// 		concurrency            int
+// 		indexInfos             indexInfos


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (indexInfos) found (dupword)

github-actions · 2023-07-04T10:43:16Z

pkg/manager/index/service/indexer_test.go

+// 		saveIndexWaitDuration  time.Duration
+// 		saveIndexTargetAddrCh  chan string
+// 		concurrency            int
+// 		indexInfos             indexInfos


🚫 [golangci] _{reported by reviewdog 🐶}
Duplicate words (indexInfos) found (dupword)

codecov · 2023-07-04T10:48:24Z

Codecov Report

Patch coverage has no change and project coverage change: +0.77 🎉

Comparison is base (a46ac9e) 29.89% compared to head (185239f) 30.66%.

❗ Current head 185239f differs from pull request most recent head a96a408. Consider uploading reports for the commit a96a408 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   29.89%   30.66%   +0.77%     
==========================================
  Files         369      347      -22     
  Lines       35091    34255     -836     
==========================================
+ Hits        10489    10505      +16     
+ Misses      24118    23272     -846     
+ Partials      484      478       -6

see 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: kpango <kpango@vdaas.org>

cloudflare-workers-and-pages · 2023-07-06T04:28:29Z

Deploying with Cloudflare Pages

Latest commit:	`a96a408`
Status:	✅ Deploy successful!
Preview URL:	https://02d4a260.vald.pages.dev
Branch Preview URL:	https://test-re-generate-tests.vald.pages.dev

View logs

This reverts commit a6d8701.

github-actions bot added team/set SET team area/discoverer area/manager/index area/internal area/agent/core area/agent/sidecar area/tools/cli/loadtest area/gateway/lb area/gateway/filter size/XXXL type/test Adding tests priority/low labels Jul 4, 2023

kpango requested review from a team, vankichi and hlts2 and removed request for a team July 4, 2023 10:13

sonatype-lift bot reviewed Jul 4, 2023

View reviewed changes

github-actions bot reviewed Jul 4, 2023

View reviewed changes

vankichi approved these changes Jul 5, 2023

View reviewed changes

kevindiu approved these changes Jul 6, 2023

View reviewed changes

hlts2 approved these changes Jul 6, 2023

View reviewed changes

Re-Generate test codes

a96a408

Signed-off-by: kpango <kpango@vdaas.org>

vankichi force-pushed the test/re-generate-tests branch from 185239f to a96a408 Compare July 6, 2023 04:28

vankichi merged commit a6d8701 into main Jul 6, 2023

vankichi deleted the test/re-generate-tests branch July 6, 2023 04:34

hlts2 mentioned this pull request Sep 13, 2023

[patch] Release v1.7.7 #2180

Merged

ykadowak added a commit that referenced this pull request Nov 30, 2023

Revert "Re-Generate test codes (#2107)"

8d77239

This reverts commit a6d8701.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-Generate test codes #2107

Re-Generate test codes #2107

kpango commented Jul 4, 2023

vdaas-ci commented Jul 4, 2023

sonatype-lift bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

github-actions bot Jul 4, 2023

codecov bot commented Jul 4, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 6, 2023 •

edited

Loading

File Path	Line Number
internal/conv/conv_test.go	397
internal/conv/conv_test.go	398
internal/log/mock/logger_test.go	852
internal/log/mock/logger_test.go	853
internal/log/mock/logger_test.go	854
internal/log/mock/logger_test.go	985
internal/log/mock/logger_test.go	986
internal/log/mock/logger_test.go	1119

Command	Usage
`@sonatype-lift ignore`	Leave out the above finding from this PR
`@sonatype-lift ignoreall`	Leave out all the existing findings from this PR
`@sonatype-lift exclude <file\|issue\|path\|tool>`	Exclude specified `file\|issue\|path\|tool` from Lift findings by updating your config.toml file

Re-Generate test codes #2107

Re-Generate test codes #2107

Conversation

kpango commented Jul 4, 2023

Description:

Related Issue:

Versions:

Checklist:

Special notes for your reviewer:

vdaas-ci commented Jul 4, 2023

sonatype-lift bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

github-actions bot Jul 4, 2023

Choose a reason for hiding this comment

codecov bot commented Jul 4, 2023 • edited Loading

Codecov Report

cloudflare-workers-and-pages bot commented Jul 6, 2023 • edited Loading

Deploying with Cloudflare Pages

codecov bot commented Jul 4, 2023 •

edited

Loading

cloudflare-workers-and-pages bot commented Jul 6, 2023 •

edited

Loading