Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix format network policy document #2108

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Fix format network policy document #2108

merged 2 commits into from
Jul 5, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jul 4, 2023

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vankichi
📝 Fix format network policy document
a24ee12 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi requested review from ykadowak, a team and kpango and removed request for a team July 4, 2023 12:12
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 4, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 4, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2c37c29
Status: ✅  Deploy successful!
Preview URL: https://3945b9c8.vald.pages.dev
Branch Preview URL: https://documentation-docs-fix-forma.vald.pages.dev

View logs

kpango
kpango approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit ffc0492 into main Jul 5, 2023
@vankichi vankichi deleted the documentation/docs/fix-format-network-policy-docs branch July 5, 2023 01:00
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix format network policy document (#2108)"
537d8a2 
This reverts commit ffc0492.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
priority/low size/S type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kpango @ykadowak