Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix variable type definition for using gache #2123

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Fix variable type definition for using gache #2123

merged 4 commits into from
Jul 11, 2023

Conversation

vankichi
Copy link
Contributor

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.20.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.13

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@github-actions github-actions bot added size/L type/bug Something isn't working priority/medium labels Jul 11, 2023
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.10 🎉

Comparison is base (e52eb4a) 31.13% compared to head (6412beb) 31.24%.

❗ Current head 6412beb differs from pull request most recent head 830a1ba. Consider uploading reports for the commit 830a1ba to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2123      +/-   ##
==========================================
+ Coverage   31.13%   31.24%   +0.10%     
==========================================
  Files         339      311      -28     
  Lines       32791    27580    -5211     
==========================================
- Hits        10211     8616    -1595     
+ Misses      22131    18684    -3447     
+ Partials      449      280     -169
Impacted Files Coverage Δ
internal/k8s/pod/pod.go 0.00% <ø> (ø)
internal/core/algorithm/ngt/ngt.go 62.09% <50.00%> (-0.89%) ⬇️

... and 32 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 11, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bff957d
Status:⚡️  Build in progress...

View logs

@vankichi vankichi force-pushed the bugfix/internal/fix-gache-type branch from 7752e3f to 259a276 Compare July 11, 2023 15:41
@vankichi vankichi force-pushed the bugfix/internal/fix-gache-type branch 2 times, most recently from 6412beb to a1cb9b6 Compare July 11, 2023 15:48
@vankichi
🐛 Fix internal/gache definition variable type
bb7745c 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the bugfix/internal/fix-gache-type branch from a1cb9b6 to bb7745c Compare July 11, 2023 15:52
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/bugfix%2Finternal%2Ffix-gache-type/075c0b610ab27c6716d924bc266982acf7c83229

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@vankichi vankichi requested review from kpango and ykadowak July 11, 2023 16:33
@vankichi vankichi changed the title Fix internal/gache definition variable type Fix definition variable type for using gache Jul 11, 2023
@vankichi vankichi changed the title Fix definition variable type for using gache Fix variable type definition for using gache Jul 11, 2023
kpango
kpango approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added size/M and removed size/M labels Jul 11, 2023
@kpango kpango merged commit b92e4bc into main Jul 11, 2023
22 of 25 checks passed
@kpango kpango deleted the bugfix/internal/fix-gache-type branch July 11, 2023 23:04
ykadowak pushed a commit that referenced this pull request Jul 25, 2023
@vankichi @kpango @ykadowak
🐛 Fix internal/gache definition variable type (#2123)
2e646dc 
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert ":bug: Fix internal/gache definition variable type (#2123)"
6b0333f 
This reverts commit b92e4bc.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert ":bug: Fix internal/gache definition variable type (#2123)"
c63aa86 
This reverts commit b92e4bc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevindiu kevindiu kevindiu approved these changes

@kpango kpango kpango approved these changes

@ykadowak ykadowak Awaiting requested review from ykadowak

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core area/discoverer area/internal priority/medium size/L type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @kpango