Fix ngt index path of test case #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
team/set
hlts2
requested review from
a team,
kmrmt,
kevindiu and
kpango
and removed request for
a team
kpango
previously approved these changes
Jul 12, 2023
kevindiu
previously approved these changes
Jul 12, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
- Coverage 31.12% 31.10% -0.03%
==========================================
Files 337 339 +2
Lines 32778 32831 +53
==========================================
+ Hits 10202 10211 +9
- Misses 22128 22167 +39
- Partials 448 453 +5
☔ View full report in Codecov by Sentry. |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
| Latest commit: |
428219b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9f4670eb.vald.pages.dev |
| Branch Preview URL: | https://bugfix-test-agent-ngt-index.vald.pages.dev |
kevindiu
previously approved these changes
Jul 12, 2023
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
ykadowak
approved these changes
Jul 12, 2023
kpango
pushed a commit
that referenced
this pull request
Jul 20, 2023
Signed-off-by: kpango <kpango@vdaas.org>
ykadowak
pushed a commit
that referenced
this pull request
Jul 25, 2023
* fix index path for test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use t.TempDir for index path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * create inde temp directory and fix fails test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactoring comprator Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
kpango
added a commit
that referenced
this pull request
Aug 31, 2023
Signed-off-by: kpango <kpango@vdaas.org>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
WHAT
I fixed index path of test case
WHY
The test failed because it was the same index path as the other test cases.
https://github.com/vdaas/vald/blob/main/internal/core/algorithm/ngt/ngt_test.go#L1807-L1832
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: