Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add apiversion capabilities check to helm template #2137

Merged
merged 2 commits into from
Jul 26, 2023
Merged

add apiversion capabilities check to helm template #2137

merged 2 commits into from
Jul 26, 2023

Conversation

datelier
Copy link
Contributor

Description:

Add apiversion capabilities check.

  • checked k8s version: v1.24.x - v1.27.x

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@datelier datelier requested review from a team, kpango and ykadowak and removed request for a team July 25, 2023 01:58
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

kpango
kpango approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 26, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cdc4f25
Status: ✅  Deploy successful!
Preview URL: https://a9467885.vald.pages.dev
Branch Preview URL: https://feature-helm-check-apiversio.vald.pages.dev

View logs

@kpango kpango enabled auto-merge July 26, 2023 04:46
@kpango kpango disabled auto-merge July 26, 2023 05:00
@kpango kpango merged commit dda49f0 into main Jul 26, 2023
@kpango kpango deleted the feature/helm/check-apiversion branch July 26, 2023 05:01
ykadowak added a commit that referenced this pull request Aug 2, 2023
@ykadowak
Revert "add apiversion capabilities check to helm template (#2137)"
c32ee5b 
This reverts commit dda49f0.
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add apiversion capabilities check to helm template (#2137)"
12ed726 
This reverts commit dda49f0.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add apiversion capabilities check to helm template (#2137)"
c475790 
This reverts commit dda49f0.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "add apiversion capabilities check to helm template (#2137)"
880fe54 
This reverts commit dda49f0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykadowak ykadowak ykadowak approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/helm priority/medium size/S type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@datelier @vdaas-ci @kpango @ykadowak