Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage CI error #2150

Merged
merged 8 commits into from
Aug 7, 2023
Merged

Fix coverage CI error #2150

merged 8 commits into from
Aug 7, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Aug 4, 2023

Description:

This PR fixes coverage CI test error.

  • Add short flag skip for performance test
  • Stop sending coverage to deepsource since we're not using it right now

Related Issue:

Versions:

  • Go Version: 1.20.6
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.27.3
  • NGT Version: 2.0.16

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (760d586) 31.18% compared to head (39ec638) 31.17%.

❗ Current head 39ec638 differs from pull request most recent head 7c253dd. Consider uploading reports for the commit 7c253dd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
- Coverage   31.18%   31.17%   -0.01%     
==========================================
  Files         339      339              
  Lines       32920    32920              
==========================================
- Hits        10266    10264       -2     
+ Misses      22202    22200       -2     
- Partials      452      456       +4     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ykadowak ykadowak requested review from a team, kpango and hlts2 and removed request for a team August 4, 2023 02:35
@ykadowak ykadowak changed the title Fix coverage CI Fix coverage CI error Aug 4, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c253dd
Status: ✅  Deploy successful!
Preview URL: https://c6f25b41.vald.pages.dev
Branch Preview URL: https://fix-ci-coverage.vald.pages.dev

View logs

@ykadowak ykadowak requested a review from hlts2 August 4, 2023 05:56
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 merged commit 734cd4f into main Aug 7, 2023
14 checks passed
@hlts2 hlts2 deleted the fix/ci/coverage branch August 7, 2023 04:37
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants