Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate make command #2165

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Fix duplicate make command #2165

merged 2 commits into from
Aug 31, 2023

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Aug 31, 2023 •
edited
Loading

Description:

I fixed a duplicate make command declaration.

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@hlts2
fix duplicate make command
bbe7695 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested review from a team, kevindiu, kpango and vankichi and removed request for a team and kevindiu August 31, 2023 06:53
@github-actions github-actions bot added team/sre SRE team area/makefile size/S type/bug Something isn't working labels Aug 31, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 31, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3f1b4cc
Status: ✅  Deploy successful!
Preview URL: https://ebc77a87.vald.pages.dev
Branch Preview URL: https://bugfix-makefile-e2e-command.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vankichi vankichi merged commit ac21880 into main Aug 31, 2023
17 checks passed
@vankichi vankichi deleted the bugfix/makefile/e2e-command branch August 31, 2023 07:18
kpango pushed a commit that referenced this pull request Sep 6, 2023
@hlts2 @kpango
Fix duplicate make command (#2165)
63e4c60 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
@kpango
Fix duplicate make command (#2165)
cec4343 
fix

Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
@kpango
Fix duplicate make command (#2165)
d91c758 
Signed-off-by: kpango <kpango@vdaas.org>
kpango added a commit that referenced this pull request Sep 6, 2023
@kpango
Fix duplicate make command (#2165)
63b698f 
Signed-off-by: kpango <kpango@vdaas.org>
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
c4ccbc0 
This reverts commit ac21880.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
f753564 
This reverts commit ac21880.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
d166da9 
This reverts commit ac21880.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
f5fd1e4 
This reverts commit ac21880.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
8f91dd9 
This reverts commit ac21880.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Fix duplicate make command (#2165)"
6f3db89 
This reverts commit ac21880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vankichi vankichi vankichi approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
area/makefile priority/medium size/S team/sre SRE team type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kpango @vankichi