Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor search status #2168

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 6, 2023

Description:

Remove unnecessary goroutine execution from search logic.
And refine gRPC status code.

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 6, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head 9786def differs from pull request most recent head 217dfb2. Consider uploading reports for the commit 217dfb2 to get more accurate results

Files Changed Coverage
cmd/agent/core/ngt/main.go ø
cmd/agent/sidecar/main.go ø
cmd/discoverer/k8s/main.go ø
cmd/gateway/filter/main.go ø
cmd/gateway/lb/main.go ø
cmd/manager/index/main.go ø
cmd/tools/cli/loadtest/main.go ø
cmd/tools/cli/vdctl/main.go ø
hack/benchmark/assets/x1b/loader.go ø
hack/benchmark/core/benchmark/benchmark.go ø
... and 22 more

📢 Thoughts on this report? Let us know!.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 6, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

Signed-off-by: kpango <kpango@vdaas.org>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 217dfb2
Status:⚡️  Build in progress...

View logs

@kpango kpango force-pushed the refactor/lbgw/aggregation-search-status branch from 9786def to ca54ef5 Compare September 6, 2023 06:32
@github-actions github-actions bot removed team/set SET team team/sre SRE team labels Sep 6, 2023
@kpango kpango changed the title [WIP] Refactor search status Refactor search status Sep 6, 2023
@kpango kpango marked this pull request as ready for review September 6, 2023 06:35
@kpango kpango requested review from a team, kmrmt and kevindiu and removed request for a team September 6, 2023 06:44
@kpango kpango merged commit 74be94c into main Sep 7, 2023
12 of 14 checks passed
@kpango kpango deleted the refactor/lbgw/aggregation-search-status branch September 7, 2023 07:16
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants