Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bbolt as internal/db/kvs #2177

Merged
merged 23 commits into from
Sep 15, 2023
Merged

Add bbolt as internal/db/kvs #2177

merged 23 commits into from
Sep 15, 2023

Conversation

ykadowak
Copy link
Contributor

@ykadowak ykadowak commented Sep 11, 2023 •
edited
Loading

Description:

This PR adds bbolt as internal/db/kvs.

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions[bot]
github-actions bot reviewed Sep 11, 2023
View reviewed changes
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch coverage is 36.28% of modified lines.

❗ Current head 097c138 differs from pull request most recent head aadaed9. Consider uploading reports for the commit aadaed9 to get more accurate results

Files Changed Coverage
internal/db/kvs/bbolt/option.go 0.00%
internal/db/kvs/bbolt/bbolt.go 65.07%

📢 Thoughts on this report? Let us know!.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 12, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: aadaed9
Status: ✅  Deploy successful!
Preview URL: https://d1e1174a.vald.pages.dev
Branch Preview URL: https://feature-internal-kvs-bbolt.vald.pages.dev

View logs

@ykadowak ykadowak requested review from kpango, a team and hlts2 and removed request for a team September 12, 2023 01:52
kpango
kpango requested changes Sep 12, 2023
View reviewed changes
internal/db/kvs/bbolt/bbolt.go Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
internal/db/kvs/bbolt/bbolt.go Outdated Show resolved Hide resolved
@ykadowak ykadowak requested a review from hlts2 September 14, 2023 01:38
@github-actions github-actions bot added size/XXL and removed size/L labels Sep 15, 2023
@ykadowak ykadowak merged commit a95676a into main Sep 15, 2023
62 of 63 checks passed
@ykadowak ykadowak deleted the feature/internal/kvs-bbolt branch September 15, 2023 06:16
@ykadowak ykadowak mentioned this pull request Sep 15, 2023
Closed
2 tasks
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
fb4e7e3 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
0f7994b 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
a55fc1e 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
aa5d229 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
48f2a2e 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
5ba6f01 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
3c474db 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
18f5de9 
This reverts commit a95676a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "Add bbolt as internal/db/kvs (#2177)"
63dad88 
This reverts commit a95676a.
@vankichi vankichi mentioned this pull request Dec 4, 2023
Merged
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@ykadowak @kmrmt
Add bbolt as internal/db/kvs (#2177)
6948710 
* Add bbolt kvs

* changed key type to []byte

* combine types

* add license

* add interface

* use test template

* use interface type as input parameter

* Split test cases

* Have bucket as []byte in the struct

* remove unused bbolt error

* refactor

* add filemode as func arg

* refactor

* fix recover from file

* apply format

* add functional option for bbolt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@hlts2 hlts2 hlts2 approved these changes

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
area/internal priority/medium size/XXL team/set SET team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykadowak @vdaas-ci @kpango @hlts2