Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List kvs and vqueue data #2188

Merged
merged 4 commits into from
Sep 15, 2023
Merged

List kvs and vqueue data #2188

merged 4 commits into from
Sep 15, 2023

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Sep 15, 2023 •
edited
Loading

Description:

I added new function to get all kvs and vqueue data.

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

@hlts2
list kvs and vqueue data
05dbd1e 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

kpango
kpango previously approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8ee5e5
Status: ✅  Deploy successful!
Preview URL: https://a32b572f.vald.pages.dev
Branch Preview URL: https://feature-agent-list-all-data.vald.pages.dev

View logs

@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/feature%2Fagent%2Flist-all-data/87a775acae945b7203f791eeb59fadde653b5feb

@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@hlts2
add function comment
b8ee5e5 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango September 15, 2023 02:36
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

Files Changed Coverage
pkg/agent/core/ngt/service/ngt.go 0.00%
pkg/agent/core/ngt/service/vqueue/queue.go 0.00%

📢 Thoughts on this report? Let us know!.

@kpango kpango merged commit 622579a into main Sep 15, 2023
33 of 36 checks passed
@kpango kpango deleted the feature/agent/list-all-data branch September 15, 2023 03:09
@kpango kpango mentioned this pull request Sep 15, 2023
Merged
This was referenced Sep 20, 2023
Merged
Merged
Merged
Merged
This was referenced Oct 24, 2023
Merged
Merged
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
2fef497 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
b35133e 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
08af15c 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
7d71a5a 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
2eea7aa 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
2d17641 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
2fb79b6 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
58667fe 
This reverts commit 622579a.
ykadowak added a commit that referenced this pull request Nov 30, 2023
@ykadowak
Revert "List kvs and vqueue data (#2188)"
8e11501 
This reverts commit 622579a.
kmrmt pushed a commit that referenced this pull request Dec 12, 2023
@hlts2 @kpango @kmrmt
List kvs and vqueue data (#2188)
06d6e08 
* list kvs and vqueue data

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* add function comment

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

---------

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@vankichi vankichi vankichi approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling actions/fossa area/agent/core priority/medium size/M type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kpango @vankichi