-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returns all connection information in the registration rpc #2199
Merged
hlts2
merged 3 commits into
feature/mirror-gateway-definition
from
refactor/mirror-gateway
Oct 2, 2023
Merged
Returns all connection information in the registration rpc #2199
hlts2
merged 3 commits into
feature/mirror-gateway-definition
from
refactor/mirror-gateway
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Deploying with
|
Latest commit: |
fdcfac9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://0c68d29f.vald.pages.dev |
Branch Preview URL: | https://refactor-mirror-gateway.vald.pages.dev |
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
[WARNING:INTCFG] Changes in |
5ea8d4f
into
feature/mirror-gateway-definition
105 of 107 checks passed
hlts2
added a commit
that referenced
this pull request
Jan 19, 2024
* add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Rename ip to host of proto payload field for mirror gateway (#2031) * fix field name and yaml indent Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix docker build for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "fix docker build for mirror" This reverts commit 53ab94f. * fix docker build error for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add Custom Resource for mirror target (#2023) * add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add discovery logic for other mirror target Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add k8s template file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add crd for mirror target resource Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new values for mirror discovery logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * fix schema register error and fix manifest to multi vald cluster Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * bugfix: adapt the service account and add early return Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: usage of errors join Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: type conversion bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix metadata hash logic and add mirror group function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status handling for network connection Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactoring Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: status update handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: update status using status writer Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status timestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix yaml field format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * improve status changes handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * reduced number of status updates Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * added status check handling before changing status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update vald mirror target definition and add new cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * deploy multiple vald clusters and mirror target resource to connect with each other Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix e2d test to mirror-gateway and crd view field Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * define mirror app name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix golangci warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * crd generate command for mirror target using mirror-target-values Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add string field validation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add configuration comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * add image tag for debug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix rebase error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix wait timeout option Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new option to set mirror address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix for ingress configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create lb ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create filter ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for unimplemented codes error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix register addr process Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "update docker file for build error" This reverts commit f40986d. * add new package for docker build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway example (#2082) * add example code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute search and getobject request to all vald clusters Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fixed to send data to each cluster based on the dataset Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror target metrics Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix example ngt dimension Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix mirror image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway document (#2105) * add mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix svg to png Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Apply suggestions from code review * Update docs/overview/component/mirror-gateway.md * fix expand bug for mirror tutorial Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix filename typo Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster role settings for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add hdf5 installation section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * update link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * delete quote Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> * Update docs/overview/component/mirror-gateway.md * Update docs/api/mirror-gateway.md Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * Update docs/api/mirror-gateway.md * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * merge ingress configuration for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix duplicate definition error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make schema update & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix test execution error for mirror handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all format and update schema and fails build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use resuable workflow to build mirror image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use internal sync package and refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add network policy settings and update deploy command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add default setting logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new fileld to crd schema and update crd Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix make command to deploy vald with mirror components Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add e2e test for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command to get pod status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * disable sidecar e2e and add mirror e2e command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster-info dump command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "add cluster-info dump command" This reverts commit 7ece16f. * debug: add logs command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "debug: add logs command" This reverts commit 454eaf3. * add RemoveByTimestamp for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update sleep time for operator deploy Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update wait time for vmt Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Returns all connection information in the registration rpc (#2199) * fix: returns all connection information in the registration rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: deleted unnecessary parameter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add handler logic to continue processing (#2204) * feat: add new crud logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: error handling logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix error handling for rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for RemoveByTimestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: fails error test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: test logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new condition and add test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: error handling and comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: test case name and test case order Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: execute format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update Mirror Gateway document (#2207) * fix: update mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add removeByTimestamp section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning and refactor document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror gateway troubleshooting docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 2c492f7 according to the output from Gofumpt and Prettier. Details: #2207 * feat: add contents of troubleshooting document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary contents Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: status handling logic document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: document refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix status handling document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor sentence Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * feat: schema and protobuf update Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning and add comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 7d7a690 according to the output from Gofumpt and Prettier. Details: #2237 * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: move mirror client mock definition to internal package Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add new handler base logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor stream list object rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: divide logic to other function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in e62a657 according to the output from Gofumpt and Prettier. Details: #2237 * make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: return grpc error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror service test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add mock definition code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in d6580ec according to the output from Gofumpt and Prettier. Details: #2237 * fix: use internal method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete Exist method because it is not needed Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: use address cache insted of connectedAddr method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: improve connection management and add new test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for syncronizee based on address and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: improve error handling and example image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: schema update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update charts/vald/values/multi-vald/dev-vald-with-mirror.yaml * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 4c11568 according to the output from Gofumpt and Prettier. Details: #2262 * fix: reviewdog warning and deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: use new command to docker build Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update schema and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary RPCs due to failure of previous rebasing Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: proto and execute make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: revert unnecessary changes Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: apply feedback for comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add internal hash package to generate hash value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ignore deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add function and method comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update pkg/gateway/mirror/handler/grpc/handler.go * fix: schema and proto update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add ingress rule for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted wildcard path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ingress unified into one manifest Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lb ingress port settings and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add cluster wide ingress resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add deploy ingress resource using make command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
ykadowak
added a commit
that referenced
this pull request
Jan 21, 2024
* add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Rename ip to host of proto payload field for mirror gateway (#2031) * fix field name and yaml indent Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix docker build for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "fix docker build for mirror" This reverts commit 53ab94f. * fix docker build error for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add Custom Resource for mirror target (#2023) * add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add discovery logic for other mirror target Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add k8s template file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add crd for mirror target resource Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new values for mirror discovery logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * fix schema register error and fix manifest to multi vald cluster Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * bugfix: adapt the service account and add early return Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: usage of errors join Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: type conversion bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix metadata hash logic and add mirror group function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status handling for network connection Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactoring Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: status update handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: update status using status writer Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status timestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix yaml field format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * improve status changes handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * reduced number of status updates Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * added status check handling before changing status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update vald mirror target definition and add new cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * deploy multiple vald clusters and mirror target resource to connect with each other Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix e2d test to mirror-gateway and crd view field Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * define mirror app name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix golangci warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * crd generate command for mirror target using mirror-target-values Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add string field validation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add configuration comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * add image tag for debug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix rebase error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix wait timeout option Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new option to set mirror address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix for ingress configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create lb ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create filter ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for unimplemented codes error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix register addr process Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "update docker file for build error" This reverts commit f40986d. * add new package for docker build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway example (#2082) * add example code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute search and getobject request to all vald clusters Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fixed to send data to each cluster based on the dataset Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror target metrics Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix example ngt dimension Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix mirror image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway document (#2105) * add mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix svg to png Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Apply suggestions from code review * Update docs/overview/component/mirror-gateway.md * fix expand bug for mirror tutorial Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix filename typo Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster role settings for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add hdf5 installation section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * update link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * delete quote Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> * Update docs/overview/component/mirror-gateway.md * Update docs/api/mirror-gateway.md Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * Update docs/api/mirror-gateway.md * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * merge ingress configuration for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix duplicate definition error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make schema update & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix test execution error for mirror handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all format and update schema and fails build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use resuable workflow to build mirror image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use internal sync package and refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add network policy settings and update deploy command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add default setting logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new fileld to crd schema and update crd Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix make command to deploy vald with mirror components Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add e2e test for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command to get pod status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * disable sidecar e2e and add mirror e2e command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster-info dump command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "add cluster-info dump command" This reverts commit 7ece16f. * debug: add logs command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "debug: add logs command" This reverts commit 454eaf3. * add RemoveByTimestamp for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update sleep time for operator deploy Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update wait time for vmt Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Returns all connection information in the registration rpc (#2199) * fix: returns all connection information in the registration rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: deleted unnecessary parameter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add handler logic to continue processing (#2204) * feat: add new crud logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: error handling logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix error handling for rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for RemoveByTimestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: fails error test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: test logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new condition and add test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: error handling and comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: test case name and test case order Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: execute format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update Mirror Gateway document (#2207) * fix: update mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add removeByTimestamp section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning and refactor document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror gateway troubleshooting docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 2c492f7 according to the output from Gofumpt and Prettier. Details: #2207 * feat: add contents of troubleshooting document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary contents Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: status handling logic document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: document refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix status handling document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor sentence Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * feat: schema and protobuf update Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning and add comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 7d7a690 according to the output from Gofumpt and Prettier. Details: #2237 * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: move mirror client mock definition to internal package Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add new handler base logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor stream list object rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: divide logic to other function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in e62a657 according to the output from Gofumpt and Prettier. Details: #2237 * make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: return grpc error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror service test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add mock definition code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in d6580ec according to the output from Gofumpt and Prettier. Details: #2237 * fix: use internal method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete Exist method because it is not needed Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: use address cache insted of connectedAddr method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: improve connection management and add new test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for syncronizee based on address and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: improve error handling and example image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: schema update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update charts/vald/values/multi-vald/dev-vald-with-mirror.yaml * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 4c11568 according to the output from Gofumpt and Prettier. Details: #2262 * fix: reviewdog warning and deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: use new command to docker build Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update schema and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary RPCs due to failure of previous rebasing Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: proto and execute make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: revert unnecessary changes Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: apply feedback for comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add internal hash package to generate hash value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ignore deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add function and method comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update pkg/gateway/mirror/handler/grpc/handler.go * fix: schema and proto update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add ingress rule for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted wildcard path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ingress unified into one manifest Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lb ingress port settings and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add cluster wide ingress resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add deploy ingress resource using make command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
vankichi
added a commit
that referenced
this pull request
Jan 22, 2024
* Add mirror gateway definitions and Implementations (#2262) * add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Rename ip to host of proto payload field for mirror gateway (#2031) * fix field name and yaml indent Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/add & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix docker build for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "fix docker build for mirror" This reverts commit 53ab94f. * fix docker build error for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add Custom Resource for mirror target (#2023) * add mirror definition and update proto dependencies Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway component (#1949) * add mirror component Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror dockerfile path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix insert rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix api resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror service and fix handler logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix values and helm template for new configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with gofumpt and prettier * fix template rendering bug of mirror configmap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix nil pointer error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix to advertize different address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * returns error when there is no other mirror gateways Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add info log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * extract only mirror addresses Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix log variable Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add logging Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix mirror connection logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api proxy implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for register API Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix debug message Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor discover logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add remove api Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * add remove api and remove api rollback logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add update rpc handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor context variable for grpc method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace span name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add getObjects method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor update and remove handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add multi handler implementation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix mirror client trace span Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * rename discover service to mirror service Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error of bidirectional stream Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add more error handling to search handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status code log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix named return bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add force status wrap Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute upsert method to local cluster's lb Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add target debug log Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix delete unwrap of circuitbreaker Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor error handling for new status parse function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Format code with prettier and gofumpt * refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix error handling for broadcast operation of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error join bug of getobject Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix status handling and add address to resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use vald client for update operation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add rollback test for mirror crud Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor mirror servie Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix trace attribute and refactor variable name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling when crud rpc fails Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "make format" This reverts commit f605563. * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * apply suggestion Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix and refactor mirror client Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * add discovery logic for other mirror target Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add k8s template file Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add crd for mirror target resource Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new values for mirror discovery logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * fix schema register error and fix manifest to multi vald cluster Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * bugfix: adapt the service account and add early return Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: usage of errors join Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: type conversion bug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix metadata hash logic and add mirror group function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status handling for network connection Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactoring Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: status update handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix: update status using status writer Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add status timestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix yaml field format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * improve status changes handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * reduced number of status updates Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * added status check handling before changing status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update vald mirror target definition and add new cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * deploy multiple vald clusters and mirror target resource to connect with each other Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix e2d test to mirror-gateway and crd view field Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * define mirror app name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * deleted unused code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix golangci warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * crd generate command for mirror target using mirror-target-values Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add string field validation Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add configuration comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with gofumpt and prettier * add image tag for debug Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix rebase error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix wait timeout option Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new option to set mirror address Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix for ingress configuration Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create lb ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * not create filter ingress when mirror is enabled Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add error handling for unimplemented codes error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix register addr process Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "update docker file for build error" This reverts commit f40986d. * add new package for docker build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway example (#2082) * add example code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * execute search and getobject request to all vald clusters Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fixed to send data to each cluster based on the dataset Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add mirror target metrics Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix example ngt dimension Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * fix mirror image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add mirror gateway document (#2105) * add mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix svg to png Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Update docs/api/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * Apply suggestions from code review Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * style: Format code with prettier and gofumpt * Apply suggestions from code review * Update docs/overview/component/mirror-gateway.md * fix expand bug for mirror tutorial Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: Format code with prettier and gofumpt * fix filename typo Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster role settings for mirror gateway Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add hdf5 installation section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> * update link Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * delete quote Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update mirror component overview image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update docs/overview/component/mirror-gateway.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> * Update docs/overview/component/mirror-gateway.md * Update docs/api/mirror-gateway.md Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * Update docs/api/mirror-gateway.md * Update docs/user-guides/mirroring-configuration.md Co-authored-by: Kevin Diu <kevindiujp@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * merge ingress configuration for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix duplicate definition error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all & make schema update & make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix test execution error for mirror handler Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * make proto/all format and update schema and fails build error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use resuable workflow to build mirror image Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * use internal sync package and refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add network policy settings and update deploy command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add default setting logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add new fileld to crd schema and update crd Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix make command to deploy vald with mirror components Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add e2e test for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add debug command to get pod status Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * bugfix command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * disable sidecar e2e and add mirror e2e command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update cluster role Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * add cluster-info dump command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "add cluster-info dump command" This reverts commit 7ece16f. * debug: add logs command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Revert "debug: add logs command" This reverts commit 454eaf3. * add RemoveByTimestamp for mirror Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update sleep time for operator deploy Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * update wait time for vmt Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Returns all connection information in the registration rpc (#2199) * fix: returns all connection information in the registration rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: deleted unnecessary parameter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Add handler logic to continue processing (#2204) * feat: add new crud logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: error handling logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix error handling for rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for RemoveByTimestamp Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: fails error test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor: test logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new condition and add test case Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * refactor code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: error handling and comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: test case name and test case order Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: execute format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add new comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update Mirror Gateway document (#2207) * fix: update mirror document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add removeByTimestamp section Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning and refactor document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror gateway troubleshooting docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 2c492f7 according to the output from Gofumpt and Prettier. Details: #2207 * feat: add contents of troubleshooting document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: grammar Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: invalid link path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor docs Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary contents Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: status handling logic document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: document refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: bugfix status handling document Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor sentence Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> * feat: schema and protobuf update Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning and add comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 7d7a690 according to the output from Gofumpt and Prettier. Details: #2237 * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: reviewdog warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: move mirror client mock definition to internal package Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add new handler base logic Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor stream list object rpc Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: divide logic to other function Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in e62a657 according to the output from Gofumpt and Prettier. Details: #2237 * make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: return grpc error Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add mirror service test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add mock definition code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in d6580ec according to the output from Gofumpt and Prettier. Details: #2237 * fix: use internal method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: delete Exist method because it is not needed Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: use address cache insted of connectedAddr method Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: improve connection management and add new test Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: refactor error handling Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add test for syncronizee based on address and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: improve error handling and example image tag Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: schema update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update charts/vald/values/multi-vald/dev-vald-with-mirror.yaml * fix: lint warnning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in 4c11568 according to the output from Gofumpt and Prettier. Details: #2262 * fix: reviewdog warning and deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: use new command to docker build Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: update schema and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary RPCs due to failure of previous rebasing Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: proto and execute make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: revert unnecessary changes Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted unnecessary code Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make proto/all format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: apply feedback for comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add internal hash package to generate hash value Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ignore deepsource warning Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add function and method comment Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * Update pkg/gateway/mirror/handler/grpc/handler.go * fix: schema and proto update and format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add ingress rule for lb and filter Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: deleted wildcard path Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: ingress unified into one manifest Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: make format Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: lb ingress port settings and small refactor Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * feat: add cluster wide ingress resource name Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> * fix: add deploy ingress resource using make command Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com> Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com> * Update values-readreplica.yaml with new index path and in-memory mode * Update POD_NAME environment variable in e2e.yml * Add readreplica e2e logic * Refactor e2e test for read replica * Update E2E test name and add read replica rotation * Update E2E test parameters for improved performance * Refactor setup-e2e action.yaml * Refactor * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in a68a83d according to the output from Gofumpt and Prettier. Details: #2298 * Add kubectl package for Kubernetes operations * Remove unused param * Fix function parameter order in kubectl package * Refactor kubectl.go: Add copyright notice and fix error handling * FIx error handling * Prevent command injection * Apply format * Seperate k8s client initialization in TestE2EReadReplica * Fix comment * style: format code with Gofumpt and Prettier This commit fixes the style issues introduced in d127dbc according to the output from Gofumpt and Prettier. Details: #2298 --------- Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com> Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have integrated the
Advertise
logic into theRegisterAPI
. With that, I have removed unnecessary parameters.Related Issue:
Versions:
Checklist:
Special notes for your reviewer: