Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migratation to buf #2236

Merged
merged 20 commits into from
Dec 7, 2023
Merged

Migratation to buf #2236

merged 20 commits into from
Dec 7, 2023

Conversation

kmrmt
Copy link
Contributor

@kmrmt kmrmt commented Nov 15, 2023 •
edited
Loading

Description:

This is protocol buffer build migration from protoc to buf.
The migration is verified by buf 1.28.0.
It includes some breaking changes.

  • stop using vtproto.mempool not to be able to find the plugin for buf
  • change directory structure for trying to follow the buf's best practice

Related Issue:

Versions:

  • Go Version: 1.21.3
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.2
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

deepsource-autofix bot added a commit that referenced this pull request Nov 15, 2023
@deepsource-autofix
style: format code with Gofumpt and Prettier
7541b79 
This commit fixes the style issues introduced in 00613df according to the output
from Gofumpt and Prettier.

Details: #2236
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages Cloudflare Pages
Copy link

cloudflare-pages bot commented Nov 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 297e72b
Status: ✅  Deploy successful!
Preview URL: https://fce98b72.vald.pages.dev
Branch Preview URL: https://feature-protocol-buffer-migr.vald.pages.dev

View logs

kmrmt pushed a commit that referenced this pull request Nov 15, 2023
@deepsource-autofix @kmrmt
style: format code with Gofumpt and Prettier
14f35ac 
This commit fixes the style issues introduced in 00613df according to the output
from Gofumpt and Prettier.

Details: #2236
@kmrmt kmrmt force-pushed the feature/protocol-buffer/migrate-to-buf branch from 7541b79 to 14f35ac Compare November 15, 2023 01:08
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9cd436e) 29.97% compared to head (5724312) 30.27%.
Report is 8 commits behind head on main.

❗ Current head 5724312 differs from pull request most recent head 297e72b. Consider uploading reports for the commit 297e72b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2236      +/-   ##
==========================================
+ Coverage   29.97%   30.27%   +0.29%     
==========================================
  Files         370      344      -26     
  Lines       36085    32434    -3651     
==========================================
- Hits        10818     9820     -998     
+ Misses      24752    22168    -2584     
+ Partials      515      446      -69

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmrmt kmrmt marked this pull request as ready for review November 15, 2023 02:58
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

1 similar comment
@vdaas-ci
Copy link
Collaborator

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
 other images

@kmrmt
revert removed files
e1253c8 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
update tool installation
2f6326b 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
update tool installation
d9e1ea0 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix
20920f5 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix
56a0a4b 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
format
b1de327 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
go mod tidy
c173e20 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
remove vtpool
8c03fd1 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
add blank line
c770be3 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix
e6fa957 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix
a784c71 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
fix
283b5fa 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
update dependencies
929ca29 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt
formatting
e7a21ec 
Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
@kmrmt kmrmt force-pushed the feature/protocol-buffer/migrate-to-buf branch from bedc115 to e7a21ec Compare December 7, 2023 07:19
@deepsource-autofix
style: format code with Gofumpt and Prettier
f6c85fe 
This commit fixes the style issues introduced in e7a21ec according to the output
from Gofumpt and Prettier.

Details: #2236
@github-actions github-actions bot added size/L and removed size/L labels Dec 7, 2023
@github-actions github-actions bot added size/L and removed size/L labels Dec 7, 2023
kpango
kpango approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added size/L and removed size/L labels Dec 7, 2023
@kpango kpango merged commit 657f009 into main Dec 7, 2023
100 of 113 checks passed
@kpango kpango deleted the feature/protocol-buffer/migrate-to-buf branch December 7, 2023 08:40
kmrmt added a commit that referenced this pull request Dec 12, 2023
@kmrmt @deepsource-autofix
@kpango @ykadowak
Migratation to buf (#2236)
d0d116f 
* migrate to buf

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* enable vtpool

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* migration of docs and swagger generation

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* revert removed files

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* update tool installation

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* update tool installation

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* fix

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* fix

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* format

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* go mod tidy

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* remove vtpool

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* add blank line

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* fix

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* fix

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* fix

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* update dependencies

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* formatting

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>

* style: format code with Gofumpt and Prettier

This commit fixes the style issues introduced in e7a21ec according to the output
from Gofumpt and Prettier.

Details: #2236

---------

Signed-off-by: Kosuke Morimoto <ksk@vdaas.org>
Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Yusuke Kato <kpango@vdaas.org>
Co-authored-by: Yusuke Kadowaki <yusuke.kadowaki.1231@gmail.com>
@vankichi vankichi mentioned this pull request Dec 19, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@kpango kpango kpango approved these changes

@ykadowak ykadowak ykadowak approved these changes

Assignees
No one assigned
Labels
actions/e2e-chaos actions/e2e-deploy actions/e2e-max-dim actions/e2e-profiling area/agent/core area/agent/sidecar area/discoverer area/gateway/filter area/gateway/lb area/makefile area/manager/index priority/medium size/XXL team/sre SRE team type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kmrmt @vdaas-ci @kpango @ykadowak