Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker buildx cache #2261

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Dec 6, 2023

Description:

I've added Docker buildkit registry cache for vald docker image builds.
and compress each docker image with zstd for more efficient start up performance.

Related Issue:

Versions:

  • Go Version: 1.21.5
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.4
  • NGT Version: 2.1.5

Checklist:

Special notes for your reviewer:

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 6, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango changed the title add docker buildx cache [WIP] add docker buildx cache Dec 6, 2023
Copy link

cloudflare-pages bot commented Dec 6, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 35f7e84
Status: ✅  Deploy successful!
Preview URL: https://c24c9f85.vald.pages.dev
Branch Preview URL: https://refactor-makefile-ci-add-doc.vald.pages.dev

View logs

@kpango kpango requested review from a team, vankichi and datelier and removed request for a team December 6, 2023 21:53
@kpango kpango force-pushed the refactor/makefile-ci/add-docker-buildx-cache branch 5 times, most recently from c70d4c1 to 0235226 Compare December 6, 2023 23:27
@kpango kpango changed the title [WIP] add docker buildx cache Add docker buildx cache Dec 6, 2023
@kpango kpango force-pushed the refactor/makefile-ci/add-docker-buildx-cache branch from 0235226 to 93ed8bb Compare December 6, 2023 23:34
@kpango kpango requested review from hlts2 and removed request for datelier December 6, 2023 23:48
vankichi
vankichi previously approved these changes Dec 7, 2023
hlts2
hlts2 previously approved these changes Dec 7, 2023
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 💯

@vankichi vankichi self-requested a review December 7, 2023 01:31
@kpango kpango dismissed stale reviews from hlts2 and vankichi via 63bac23 December 7, 2023 05:14
@kpango kpango force-pushed the refactor/makefile-ci/add-docker-buildx-cache branch 2 times, most recently from 63bac23 to b79d097 Compare December 7, 2023 05:16
vankichi
vankichi previously approved these changes Dec 7, 2023
Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango force-pushed the refactor/makefile-ci/add-docker-buildx-cache branch from b79d097 to 35f7e84 Compare December 7, 2023 06:07
@hlts2 hlts2 self-requested a review December 7, 2023 06:29
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants